GNU bug report logs - #66172
gnu: games: Update openrct2.

Previous Next

To reply to this bug, email your comments to 66172 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Trujillo Viedma <dtviedma <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: gnu: games: Update openrct2.
Date: Sun, 24 Sep 2023 00:40:21 +0200

Hello! My name is Daniel, I'm a newbie in Guix.


This is my second patch (the first one didn't ended well: 
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=50052), so please, be 
aware that may be problems with it.


This patch updates openrct to a newer version, and fixes current issues 
(I recall the title sequences weren't working before). This is a 
considerable bump, and openrct2 builds have been splitted into some 
extra packages (openmsx, opensfx, etc...) which are also included in the 
patch.

Additionally moved openrct2 definition together with its extra packages 
(openquest was defined between those and openrct2 itself).

The total size of the package is 727.0 MiB

I tried to contact the author of the patch adding openrct2 to Guix in 
first place (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28794), 
Rutger Helling, at rhelling <at> mykolab.com but I always get an "Address not 
found" error.


Looking forward to hear from you all.

Cheers,

Dani.

Message #8 received at 66172 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Trujillo Viedma <dtviedma <at> gmail.com>
To: 66172 <at> debbugs.gnu.org
Subject: Re: bug#66172: Acknowledgement (gnu: games: Update openrct2.)
Date: Sun, 24 Sep 2023 00:42:13 +0200

[Message part 1 (text/plain, inline)]

Of course, I forgot to attach the patch. Sorry for that...

[0001-Update-openrct2.patch (text/x-patch, attachment)]

Message #11 received at 66172 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Daniel Trujillo Viedma <dtviedma <at> gmail.com>, 66172 <at> debbugs.gnu.org
Subject: Re: bug#66172: Acknowledgement (gnu: games: Update openrct2.)
Date: Sun, 24 Sep 2023 11:26:06 +0200

Am Sonntag, dem 24.09.2023 um 00:42 +0200 schrieb Daniel Trujillo
Viedma:

> Subject: [PATCH] Update: openrct2
> 
> ---
You're missing a ChangeLog for your changes.  Please try to mimic the
general layout of the commits around (for more information see chapter
22, Contributing, in the Guix manual).

>     (description
> -    "openrct2-title-sequences is a set of title sequences for
> OpenRCT2.")
> -   (license license:gpl3+)))
> +    "Contains the title sequence that is distributed with each
> release of
> +OpenRCT2.")
> +   (license license:cc-by4.0)))
Descriptions should be complete sentences ("This package contains…").

Try not to move packages around as you edit them and in general, do one
commit for one package at a time.  That is, first update title
sequences, then objects, …, then add the new packages, then update
openrct2 proper, and then if it's still needed move it to where you
want it to be in the file, all with separate commits.

Cheers

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.