GNU bug report logs - #66164
30.0.50; [PATCH] Use 'unwind-protect' in some more places in Eshell

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Porter <jporterbugs <at> gmail.com>
Subject: bug#66164: closed (Re: bug#66164: 30.0.50; [PATCH] Use
 'unwind-protect' in some more places in Eshell)
Date: Tue, 26 Sep 2023 19:35:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#66164: 30.0.50; [PATCH] Use 'unwind-protect' in some more places in Eshell

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 66164 <at> debbugs.gnu.org.

-- 
66164: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66164
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: 66164-done <at> debbugs.gnu.org
Subject: Re: bug#66164: 30.0.50; [PATCH] Use 'unwind-protect' in some more
 places in Eshell
Date: Tue, 26 Sep 2023 12:34:08 -0700

Version: 30.1

On 9/22/2023 9:49 PM, Jim Porter wrote:
> The main reason for this patch is to simplify some Eshell logic as a 
> preliminary for better support of background commands (bug#660666), 
> which in turn is a preliminary for adding job control to Eshell. 
> However, this does also fix a couple edge cases with how Eshell unwinds 
> its command forms in response to error handling (e.g. previously, 
> calling 'top-level' inside an Eshell command didn't actually exit 
> recursive editing).

Pushed to master as eef32d13da5, and closing this bug..

[Message part 3 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Use 'unwind-protect' in some more places in Eshell
Date: Fri, 22 Sep 2023 21:49:34 -0700

[Message part 4 (text/plain, inline)]

(I debated just pushing this since it's mostly an implementation detail 
in Eshell, but it's a complex-enough patch that I figured it couldn't 
hurt to see if anyone has thoughts beforehand.)

The main reason for this patch is to simplify some Eshell logic as a 
preliminary for better support of background commands (bug#660666), 
which in turn is a preliminary for adding job control to Eshell. 
However, this does also fix a couple edge cases with how Eshell unwinds 
its command forms in response to error handling (e.g. previously, 
calling 'top-level' inside an Eshell command didn't actually exit 
recursive editing).

[0001-Use-unwind-protect-in-more-places-in-Eshell.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.