GNU bug report logs - #66164
30.0.50; [PATCH] Use 'unwind-protect' in some more places in Eshell

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66164 in the body.
You can then email your comments to 66164 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Use 'unwind-protect' in some more places in Eshell
Date: Fri, 22 Sep 2023 21:49:34 -0700

[Message part 1 (text/plain, inline)]

(I debated just pushing this since it's mostly an implementation detail 
in Eshell, but it's a complex-enough patch that I figured it couldn't 
hurt to see if anyone has thoughts beforehand.)

The main reason for this patch is to simplify some Eshell logic as a 
preliminary for better support of background commands (bug#660666), 
which in turn is a preliminary for adding job control to Eshell. 
However, this does also fix a couple edge cases with how Eshell unwinds 
its command forms in response to error handling (e.g. previously, 
calling 'top-level' inside an Eshell command didn't actually exit 
recursive editing).

[0001-Use-unwind-protect-in-more-places-in-Eshell.patch (text/plain, attachment)]

Message #10 received at 66164-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: 66164-done <at> debbugs.gnu.org
Subject: Re: bug#66164: 30.0.50; [PATCH] Use 'unwind-protect' in some more
 places in Eshell
Date: Tue, 26 Sep 2023 12:34:08 -0700

Version: 30.1

On 9/22/2023 9:49 PM, Jim Porter wrote:
> The main reason for this patch is to simplify some Eshell logic as a 
> preliminary for better support of background commands (bug#660666), 
> which in turn is a preliminary for adding job control to Eshell. 
> However, this does also fix a couple edge cases with how Eshell unwinds 
> its command forms in response to error handling (e.g. previously, 
> calling 'top-level' inside an Eshell command didn't actually exit 
> recursive editing).

Pushed to master as eef32d13da5, and closing this bug..

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.