GNU bug report logs - #6602
[PATCH] make dist target for Windows

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6602 in the body.
You can then email your comments to 6602 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christoph <cschol2112 <at> googlemail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>
Subject: [PATCH] make dist target for Windows
Date: Sat, 10 Jul 2010 08:00:25 -0600

[Message part 1 (text/plain, inline)]

Glenn Morris wrote:

> Also, I keep saying this, but I strongly advise people to post patches
> like this to the bug list, since then they are much less likely to get
> forgotten / overlooked. I used to forward things there, but have given
> up. If you post things here, you basically rely on people keeping
> things in their inbox until dealt with.

Following Glenn's advice I repost my patch to this list.

Initial discussion of this patch:
http://lists.gnu.org/archive/html/emacs-devel/2010-03/msg01461.html

Thanks,
Christoph

-------- Original Message --------
Subject: Re: make dist target for Windows
Date: Sat, 03 Jul 2010 11:08:03 -0600
From: Christoph <cschol2112 <at> googlemail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
CC: Christoph <cschol2112 <at> googlemail.com>, emacs-devel <at> gnu.org

On 4/8/2010 11:51 AM, Eli Zaretskii wrote:

> Well, do you have assignment to FSF on record?  I cannot see it.  If
> you don't, please talk to Stefan and Yidong to start the paperwork.
>
> Once that is done, someone will install this for you.

I finally got my confirmation email from the FSF, that my paperwork has
been processed.

Find attached the patch to implement the make dist target for Windows.

Thanks,
Christoph

[makedistw32v6.txt (text/plain, attachment)]

Message #8 received at 6602 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Christoph <cschol2112 <at> googlemail.com>
Cc: 6602 <at> debbugs.gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Thu, 22 Jul 2010 11:19:06 +0200

On Sat, Jul 10, 2010 at 16:00, Christoph <cschol2112 <at> googlemail.com> wrote:

> On 4/8/2010 11:51 AM, Eli Zaretskii wrote:
>
>> Well, do you have assignment to FSF on record?  I cannot see it.  If
>> you don't, please talk to Stefan and Yidong to start the paperwork.
>>
>> Once that is done, someone will install this for you.
>
> I finally got my confirmation email from the FSF, that my paperwork has
> been processed.

I've you can send again the patch with ChangeLog entries, I'll be
happy to install it.

    Juanma

Message #11 received at 6602 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Christoph <cschol2112 <at> googlemail.com>
Cc: 6602 <at> debbugs.gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Thu, 22 Jul 2010 11:20:18 +0200

On Thu, Jul 22, 2010 at 11:19, Juanma Barranquero <lekktu <at> gmail.com> wrote:

> I've you

That's a weird typo, if I can say it myself.

    Juanma

Message #14 received at 6602 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Christoph <cschol2112 <at> googlemail.com>
Cc: 6602 <at> debbugs.gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Thu, 22 Jul 2010 12:01:50 +0200

On Thu, Jul 22, 2010 at 11:19, Juanma Barranquero <lekktu <at> gmail.com> wrote:

> I've you can send again the patch with ChangeLog entries, I'll be
> happy to install it.

A few questions:

> Main changes:
>
> - new parameter for configure.bat to provide path to distribution files, for example libXpm.dll

Perhaps you could mention in the docs that it accepts wildcards (at
least, it worked for me once I switched from backslashes to forward
slashes on the argument).

> - README.W32 relocated to nt/ directory (from admin/nt)

AFAICS, you've copied it, not relocated it. admin/nt/README.W32 still exists.

> - makefile.w32-in contains new target install-shortcuts to invoke addpm, so no short cuts are created when packaging

I like this change because I will be able to use "make install-bin"
and bypass addpm altogether. Great. :-)

> - new file zipdist.bat in nt/ which replaces makedist.bat from admin/nt. zipdist invokes 7zip to create the zipped binary distributions and verifies integrity.

Does make sense to keep admin/nt/makedist.bat?

    Juanma

Message #17 received at 6602 <at> debbugs.gnu.org (full text, mbox):

From: Christoph <cschol2112 <at> googlemail.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 6602 <at> debbugs.gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Thu, 22 Jul 2010 19:14:44 -0600

On 7/22/2010 4:01 AM, Juanma Barranquero wrote:

>> - new parameter for configure.bat to provide path to distribution files, for example libXpm.dll
>
> Perhaps you could mention in the docs that it accepts wildcards (at
> least, it worked for me once I switched from backslashes to forward
> slashes on the argument).

Can you post an example, please?

>> - README.W32 relocated to nt/ directory (from admin/nt)
>
> AFAICS, you've copied it, not relocated it. admin/nt/README.W32 still exists.

Yeah, I was going to propose this before doing any cleanup. README.W32 
should be removed. I will add that to the patch.

>> - makefile.w32-in contains new target install-shortcuts to invoke addpm, so no short cuts are created when packaging
>
> I like this change because I will be able to use "make install-bin"
> and bypass addpm altogether. Great. :-)

I like it, too. ;)

>> - new file zipdist.bat in nt/ which replaces makedist.bat from admin/nt. zipdist invokes 7zip to create the zipped binary distributions and verifies integrity.
>
> Does make sense to keep admin/nt/makedist.bat?

No. Same deal as with README.W32. I will add it to the new, updated patch.

Thanks for the comments.

I will send an updated patch tomorrow.

Christoph

Message #20 received at 6602 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Christoph <cschol2112 <at> googlemail.com>
Cc: 6602 <at> debbugs.gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Fri, 23 Jul 2010 03:22:57 +0200

On Fri, Jul 23, 2010 at 03:14, Christoph <cschol2112 <at> googlemail.com> wrote:

> Can you post an example, please?

??

I just used --distfiles C:/emacs/build/*.dll and it worked.

Well, to be fair, I used --distfiles C:\emacs\build\*.dll and it
failed; then I manually changed \ to / and it worked.

> I will send an updated patch tomorrow.

Great, thanks.

    Juanma

Message #23 received at 6602 <at> debbugs.gnu.org (full text, mbox):

From: Christoph <cschol2112 <at> googlemail.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 6602 <at> debbugs.gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Fri, 23 Jul 2010 21:18:02 -0600

[Message part 1 (text/plain, inline)]

On 7/22/2010 7:22 PM, Juanma Barranquero wrote:

>> I will send an updated patch tomorrow.
>
> Great, thanks.
>
>      Juanma

Find attached the new patch for the `make dist' target.

I added a Changelog and NEWS entry and removed README.W32 and 
makedist.bat files from the nt/ directory.

Christoph

[makedistw32v7.txt (text/plain, attachment)]

Message #28 received at 6602-done <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Christoph <cschol2112 <at> googlemail.com>
Cc: 6602-done <at> debbugs.gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Sat, 24 Jul 2010 15:28:41 +0200

On Sat, Jul 24, 2010 at 05:18, Christoph <cschol2112 <at> googlemail.com> wrote:

> Find attached the new patch for the `make dist' target.
>
> I added a Changelog and NEWS entry and removed README.W32 and makedist.bat
> files from the nt/ directory.

OK, thaks a lot.

A few comments (nitpicks, mostly):

 - You've added the ChangeLog entry to the root directory's ChangeLog,
instead of nt/ChangeLog. Also, it lacks an entry in admin/ChangeLog
about the changes in that directory (you've documented most of them in
the other ChangeLog, though). In some cases, as when moving files, it
is customary to put a "Moved to X/" entry in the old directory's
ChangeLog, and ad "Moved from Y/" in the new's.

- Changes to documentation files, like etc/NEWS and nt/INSTALL, must
also be documented in ChangeLog entries.

- If you're going to move a file, like README.W32, instead of

    cd admin/nt
    copy README.W32 ../../nt
    del README.W32

  or

    move admin/nt/README.W32 nt/

  please do

    bzr mv admin/nt/README.W32 nt/

  so Bazaar knows that it is the same file.

- It's best if you do these changes in a branch, and then submit a
bundle. For example, applying your patch creates a file
nt/zipdist.bat, but it has to be "bzr add"ed manually.

- Try not to introduce trailing whitespace in files you modify. Not
earth-shaking, but ugly if you have `show-trailing-whitespace' set to
t (which I recommend).

That said, I'm committing your change right now. Great work. Thanks!

    Juanma

Message #31 received at 6602 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Christoph <cschol2112 <at> googlemail.com>
Cc: 6602 <at> debbugs.gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Sat, 24 Jul 2010 15:31:51 +0200

>    bzr mv admin/nt/README.W32 nt/

Also

  bzr rm admin/nt/makedist.bat

to delete a file, for the same reason.

    Juanma

Message #34 received at 6602 <at> debbugs.gnu.org (full text, mbox):

From: Christoph <cschol2112 <at> googlemail.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 6602 <at> debbugs.gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Sat, 24 Jul 2010 16:19:03 -0600

[Message part 1 (text/plain, inline)]

On 7/24/2010 7:28 AM, Juanma Barranquero wrote:

> That said, I'm committing your change right now. Great work. Thanks!

Thanks for doing this.

After testing it in the trunk I remembered: one thing I never was quite 
sure how to fix best is the fact that when you run `make dist' on the 
trunk, the root directory the zip file contains is `trunk' (or whatever 
you named your bzr checkout), but it should be `emacs-VERSION'.

Well, I guess it helps to have the code sitting around for a while. :) 
Find attached a patch that fixes this.

The main change is that it copies all necessary files to a temporary 
directory and then creates the zip files from that. After that the 
temporary directory is removed.

This change also made `zipdist.bat' a lot simpler, since I don't need to 
do funky path processing.

Now the correct root directory (based on version) will show inside the 
zip file for the trunk as well as any pretest or final version.

There is also a minor bugfix: README.W32 was not copied to the install 
directory when using `make install'.

Christoph

[makedistw32v7.txt (text/plain, attachment)]

Message #37 received at 6602 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Christoph <cschol2112 <at> googlemail.com>
Cc: 6602 <at> debbugs.gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Sun, 25 Jul 2010 03:01:15 +0200

On Sun, Jul 25, 2010 at 00:19, Christoph <cschol2112 <at> googlemail.com> wrote:

> After testing it in the trunk I remembered: one thing I never was quite sure
> how to fix best is the fact that when you run `make dist' on the trunk, the
> root directory the zip file contains is `trunk' (or whatever you named your
> bzr checkout), but it should be `emacs-VERSION'.

I noticed, but it was always possible to make a branch emacs-VERSION
and build the dist from here.
I suppose this change is for better, but it makes more difficult to
create a dist with a root directory named other than emacs-VERSION
(for my own use, for example, I call them just VERSION, ie., 23.1,
23.2, 24.0.50, etc.). It'd be nice to have a way to customize this,
but don't lose time over it; "unzip & rename dir" is just a command
away :-)

> The main change is that it copies all necessary files to a temporary
> directory and then creates the zip files from that. After that the temporary
> directory is removed.

It is highly unlikely for the user to have a directory
nt/emacs-VERSION, but you overwrite it and then remove it, so it'd be
nice to check and refuse to do anything if it already exists. Another
option would be to write to %TEMP%/%TMP_DIST_DIR% instead of
./%TMP_DIST_DIR%

> There is also a minor bugfix: README.W32 was not copied to the install
> directory when using `make install'.

In fact, there's still a minor issue: README.W32 gets copied to
INSTALL_DIR and not removed. For example, I do all installations
in-place, and after make dist I end with a README.W32 at the root of
my trunk branch. (I've added exclusions to .(bzr|git)ignore, so it's
not much of an issue, but still...).

    Juanma

Message #40 received at 6602 <at> debbugs.gnu.org (full text, mbox):

From: Christoph <cschol2112 <at> googlemail.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 6602 <at> debbugs.gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Sat, 24 Jul 2010 20:04:57 -0600

On 7/24/2010 7:01 PM, Juanma Barranquero wrote:

> I noticed, but it was always possible to make a branch emacs-VERSION
> and build the dist from here.
> I suppose this change is for better, but it makes more difficult to
> create a dist with a root directory named other than emacs-VERSION
> (for my own use, for example, I call them just VERSION, ie., 23.1,
> 23.2, 24.0.50, etc.). It'd be nice to have a way to customize this,
> but don't lose time over it; "unzip&  rename dir" is just a command
> away :-)

True. I didn't think of that. This is just the most common use case, I 
guess. My main intention behind this was to provide an easy and 
consistent way of producing snapshot and release distributions. 
Theoretically, you can edit the value of TMP_DIST_DIR in the Makefile to 
change the directory, too.

> It is highly unlikely for the user to have a directory
> nt/emacs-VERSION, but you overwrite it and then remove it, so it'd be
> nice to check and refuse to do anything if it already exists.

Actually, the mkdir command fails and the process stops with an error, 
if the directory already exists. I tested this before I added the 
DEL_TREE command.

>> There is also a minor bugfix: README.W32 was not copied to the install
>> directory when using `make install'.
>
> In fact, there's still a minor issue: README.W32 gets copied to
> INSTALL_DIR and not removed. For example, I do all installations
> in-place, and after make dist I end with a README.W32 at the root of
> my trunk branch. (I've added exclusions to .(bzr|git)ignore, so it's
> not much of an issue, but still...).

Perhaps it should be added to `distclean'?

Christoph

Message #43 received at 6602 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Christoph <cschol2112 <at> googlemail.com>
Cc: 6602 <at> debbugs.gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Sun, 25 Jul 2010 04:55:43 +0200

On Sun, Jul 25, 2010 at 04:04, Christoph <cschol2112 <at> googlemail.com> wrote:

> True. I didn't think of that. This is just the most common use case, I
> guess. My main intention behind this was to provide an easy and consistent
> way of producing snapshot and release distributions. Theoretically, you can
> edit the value of TMP_DIST_DIR in the Makefile to change the directory, too.

Well, as I said, no sweat. If someone else besides me needs the
functionality we'll know soon enough.

> Actually, the mkdir command fails and the process stops with an error, if
> the directory already exists. I tested this before I added the DEL_TREE
> command.

Of course. Silly me. Sorry for the noise.

> Perhaps it should be added to `distclean'?

Well, somewhere in *clean*, yes :-) (I renounced trying to understand
the different clean targets a long time ago.)

    Juanma

Message #46 received at 6602 <at> debbugs.gnu.org (full text, mbox):

From: Christoph <cschol2112 <at> googlemail.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 6602 <at> debbugs.gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Sat, 24 Jul 2010 21:18:52 -0600

[Message part 1 (text/plain, inline)]

On 7/24/2010 8:55 PM, Juanma Barranquero wrote:

> Well, as I said, no sweat. If someone else besides me needs the
> functionality we'll know soon enough.

I bet we will. :)

>> Perhaps it should be added to `distclean'?
>
> Well, somewhere in *clean*, yes :-) (I renounced trying to understand
> the different clean targets a long time ago.)

I know what you mean. I added it to (top-)distclean, so at least it is 
gone whenever somebody resets to the original distribution state.

Updated patch bundle attached.

Christoph

[makedistw32v9.txt (text/plain, attachment)]

Message #49 received at 6602 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Christoph <cschol2112 <at> googlemail.com>
Cc: 6602 <at> debbugs.gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Sun, 25 Jul 2010 05:58:10 +0200

On Sun, Jul 25, 2010 at 05:18, Christoph <cschol2112 <at> googlemail.com> wrote:

> I know what you mean.

I've resorted to never using the clean targets. When I want to clean, I do

  bzr clean-tree --unknown --ignored --detritus --force
  cd nt
  configure  /* my args */
  make bootstrap info install

> Updated patch bundle attached.

Committed.

    Juanma

Message #52 received at 6602 <at> debbugs.gnu.org (full text, mbox):

From: Christoph <cschol2112 <at> googlemail.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 6602 <at> debbugs.gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Sat, 24 Jul 2010 22:44:30 -0600

On 7/24/2010 9:58 PM, Juanma Barranquero wrote:

> I've resorted to never using the clean targets. When I want to clean, I do
>
>    bzr clean-tree --unknown --ignored --detritus --force
>    cd nt
>    configure  /* my args */
>    make bootstrap info install

That just works on a checkout. Sometimes I want to restore the tarball, 
but I could just delete and re-extract I guess.

I didn't know about the clean-tree command. Gotta keep that in mind.

>> Updated patch bundle attached.
>
> Committed.

Much appreciated Juanma.

Christoph

Message #55 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sean Sieger <sean.sieger <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Sun, 25 Jul 2010 08:30:07 -0400

    > Well, as I said, no sweat. If someone else besides me needs the
    > functionality we'll know soon enough.

    I bet we will. :)

I've had a pretty busy weekend and have only been able to follow this
thread in passing.  I'll reread it and find the new instructions.
However, is there anything that you want to point out regarding changes
that'll affect the current build tomorrow?

Thank you.

Message #58 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christoph <cschol2112 <at> googlemail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Sean Sieger <sean.sieger <at> gmail.com>
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Sun, 25 Jul 2010 08:09:54 -0600

Hi Sean,

On 7/25/2010 6:30 AM, Sean Sieger wrote:

> I've had a pretty busy weekend and have only been able to follow this
> thread in passing.  I'll reread it and find the new instructions.
> However, is there anything that you want to point out regarding changes
> that'll affect the current build tomorrow?

You have to pass the additional option --distfiles 
C:/FileToIncludeInDistribution/libXpm.dll to configure.bat.

configure.bat will fail with an error if it can't find the file in the 
specified directory, i.e. if the directory or the file do not exist.

Then just run `make dist' (or `mingw32-make dist') in the nt/ directory 
and the binary distributions will be built, zipped and placed in the nt/ 
directory.

The only other requirement is 7zip, but the process will fail and tell 
you, if is not installed or not available on the Windows Path.

The `make dist' target assumes that you have run `make bootstrap' before.

Let me know if you have any other questions or issues.

Christoph

Message #61 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sean Sieger <sean.sieger <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Sun, 25 Jul 2010 13:36:47 -0400

    You have to pass the additional option --distfiles
    C:/FileToIncludeInDistribution/libXpm.dll to configure.bat.

    configure.bat will fail with an error if it can't find the file in the
    specified directory, i.e. if the directory or the file do not exist.

    Then just run `make dist' (or `mingw32-make dist') in the nt/
    directory and the binary distributions will be built, zipped and
    placed in the nt/ directory.

    The only other requirement is 7zip, but the process will fail and tell
    you, if is not installed or not available on the Windows Path.

    The `make dist' target assumes that you have run `make bootstrap' before.

    Let me know if you have any other questions or issues.

Christoph, thank you for your response and thank you for your work on
this.  It makes things more straight forward.

Message #64 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christoph <cschol2112 <at> googlemail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Mon, 26 Jul 2010 19:48:42 -0600

On 7/25/2010 6:30 AM, Sean Sieger wrote:

> I've had a pretty busy weekend and have only been able to follow this
> thread in passing.  I'll reread it and find the new instructions.
> However, is there anything that you want to point out regarding changes
> that'll affect the current build tomorrow?

You have to pass the option --distfiles C:/FileToIncludeInDistribution 
to configure.bat. This is mainly for libXpm.dll.

configure.bat will fail with an error if it can't find any files in the 
specified directory.

Then just run `make dist' (or `mingw32-make dist') and the binary 
distributions will be built, zipped and placed in the nt/ directory.

Let me know if you have any other questions.

Christoph

Message #67 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sean Sieger <sean.sieger <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Tue, 27 Jul 2010 17:08:32 -0400

Christoph <cschol2112 <at> googlemail.com> writes:

    On 7/25/2010 6:30 AM, Sean Sieger wrote:

    > I've had a pretty busy weekend and have only been able to follow this
    > thread in passing.  I'll reread it and find the new instructions.
    > However, is there anything that you want to point out regarding changes
    > that'll affect the current build tomorrow?

    You have to pass the option --distfiles C:/FileToIncludeInDistribution
    to configure.bat. This is mainly for libXpm.dll.

    configure.bat will fail with an error if it can't find any files in
    the specified directory.

    Then just run `make dist' (or `mingw32-make dist') and the binary
    distributions will be built, zipped and placed in the nt/ directory.

    Let me know if you have any other questions.

    Christoph

Thanks for this, Christoph.  Um, followed the above, having removed
libXpm.dll from \bin.

c:\emacs-24.0.50>configure --with-gcc --no-opt --enable-checking
--cflags -Ic:/xpm/include --distfiles c:/xpm/bin/libXpm.dll
--without-tiff --without-gif --with out-jpeg --without-png

libXpm.dll wasn't copied to \bin, was it supposed to?

Message #70 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sean Sieger <sean.sieger <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Tue, 27 Jul 2010 18:25:46 -0400

    You have to pass the additional option --distfiles
    C:/FileToIncludeInDistribution/libXpm.dll to configure.bat.

    configure.bat will fail with an error if it can't find the file in the
    specified directory, i.e. if the directory or the file do not exist.

    Then just run `make dist' (or `mingw32-make dist') in the nt/
    directory and the binary distributions will be built, zipped and
    placed in the nt/ directory.

    The only other requirement is 7zip, but the process will fail and tell
    you, if is not installed or not available on the Windows Path.

    The `make dist' target assumes that you have run `make bootstrap' before.

    Let me know if you have any other questions or issues.

Christoph,

I used to copy makedist to the directory containing my copy of Emacs,
now what do I do?

Um, `make dist' in \nt?

Clearly, --distfiles are only copied at packaging time?

... not at `make install', for instance libXpm.dll (the only file that I
should be adding)?

Sorry about this Juanma, I know you wanted some answers, but I can't
publish this build in good faith.

What else??  Um, yeah, I showed you an erroneous `configure' in an
earlier, replete with typos (from copying let alone copying from history
while in something other than emacs-24.0.50\nt), I got it in my head
that I am building binaries and packaging 'em up all from within \nt.
Not right?

Sorry for being dense.

Message #73 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Sean Sieger <sean.sieger <at> gmail.com>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Wed, 28 Jul 2010 00:59:59 +0200

On Tue, Jul 27, 2010 at 23:08, Sean Sieger <sean.sieger <at> gmail.com> wrote:

> c:\emacs-24.0.50>configure --with-gcc --no-opt --enable-checking
> --cflags -Ic:/xpm/include --distfiles c:/xpm/bin/libXpm.dll
> --without-tiff --without-gif --with out-jpeg --without-png
>
> libXpm.dll wasn't copied to \bin, was it supposed to?

Does your cp accept forward slashes? Does it work if you try
--distfiles c:\xpm\bin\libXpm.dll?

    Juanma

Message #76 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Sean Sieger <sean.sieger <at> gmail.com>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Wed, 28 Jul 2010 01:04:29 +0200

On Wed, Jul 28, 2010 at 00:25, Sean Sieger <sean.sieger <at> gmail.com> wrote:

> Um, `make dist' in \nt?

Yes.

> Clearly, --distfiles are only copied at packaging time?

Yes, the copy is in the dist target, after install-bin.

> Sorry about this Juanma, I know you wanted some answers, but I can't
> publish this build in good faith.

There's no rush. I can wait a week or three.

> What else??  Um, yeah, I showed you an erroneous `configure' in an
> earlier, replete with typos (from copying let alone copying from history
> while in something other than emacs-24.0.50\nt), I got it in my head
> that I am building binaries and packaging 'em up all from within \nt.
> Not right?

I cannot pase this, sorry.

One question. Why do you pass "--without-tiff --without-gif --with
out-jpeg --without-png" to configure?

We don't distribute binaries for the tiff, gif, jpeg and png
libraries, but that does not mean that you cannot build a binary that
supports them, if the user provides them.

    Juanma

Message #79 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christoph <cschol2112 <at> googlemail.com>
To: Sean Sieger <sean.sieger <at> gmail.com>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Tue, 27 Jul 2010 17:08:05 -0600

On 7/27/2010 3:08 PM, Sean Sieger wrote:

> Thanks for this, Christoph.  Um, followed the above, having removed
> libXpm.dll from \bin.
>
> c:\emacs-24.0.50>configure --with-gcc --no-opt --enable-checking
> --cflags -Ic:/xpm/include --distfiles c:/xpm/bin/libXpm.dll
> --without-tiff --without-gif --with out-jpeg --without-png
>
> libXpm.dll wasn't copied to \bin, was it supposed to?

No, it is copied to a bin/ in a temporary directory, from which the zip 
file is created. Does the zip file contain libXpm.dll?

Christoph

Message #82 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christoph <cschol2112 <at> googlemail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Juanma Barranquero <lekktu <at> gmail.com>, Sean Sieger <sean.sieger <at> gmail.com>
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Tue, 27 Jul 2010 17:25:15 -0600

On 7/27/2010 4:25 PM, Sean Sieger wrote:

> I used to copy makedist to the directory containing my copy of Emacs,
> now what do I do?

cd nt

configure --with-gcc --no-opt --enable-checking
--cflags -Ic:/xpm/include --distfiles c:/xpm/bin/libXpm.dll
--without-tiff --without-gif --with out-jpeg --without-png

mingw32-make dist

This should create 2 zip files in your nt directory which contain the 
binary distributions (full and bin only).

> Clearly, --distfiles are only copied at packaging time?
> ... not at `make install', for instance libXpm.dll (the only file that I
> should be adding)?

That's correct. libXpm.dll is the only file you need.

If you can't get it to work, do this:

mingw32-make install > build.log 2>&1

This will create a file build.log in nt with all the output from make. 
Send me the file offlist and I will try to help troubleshoot this.

For what it's worth, I just build and packaged the latest trunk and it 
worked fine.

Christoph

Message #85 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christoph <cschol2112 <at> googlemail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Juanma Barranquero <lekktu <at> gmail.com>, Sean Sieger <sean.sieger <at> gmail.com>
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Tue, 27 Jul 2010 17:32:10 -0600

On 7/27/2010 5:04 PM, Juanma Barranquero wrote:

> One question. Why do you pass "--without-tiff --without-gif --with
> out-jpeg --without-png" to configure?
>
> We don't distribute binaries for the tiff, gif, jpeg and png
> libraries, but that does not mean that you cannot build a binary that
> supports them, if the user provides them.

I agree. Those arguments should be removed from configure.

Christoph

Message #88 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sean Sieger <sean.sieger <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Tue, 27 Jul 2010 21:31:38 -0400

    One question. Why do you pass "--without-tiff --without-gif --with
    out-jpeg --without-png" to configure?

Because I thought it was my experience that configure coughs if it
hasn't been passed these and cannot find the requisite dlls.

    We don't distribute binaries for the tiff, gif, jpeg and png
    libraries, but that does not mean that you cannot build a binary that
    supports them, if the user provides them.

Noted.  I'll try again.

Message #91 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sean Sieger <sean.sieger <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Tue, 27 Jul 2010 21:34:24 -0400

    Does your cp accept forward slashes? Does it work if you try
    --distfiles c:\xpm\bin\libXpm.dll?

I'll check.

Message #94 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sean Sieger <sean.sieger <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Tue, 27 Jul 2010 21:33:37 -0400

Christoph <cschol2112 <at> googlemail.com> writes:

    On 7/27/2010 4:25 PM, Sean Sieger wrote:

    > I used to copy makedist to the directory containing my copy of Emacs,
    > now what do I do?

    cd nt

    configure --with-gcc --no-opt --enable-checking
    --cflags -Ic:/xpm/include --distfiles c:/xpm/bin/libXpm.dll
    --without-tiff --without-gif --with out-jpeg --without-png

    mingw32-make dist

    This should create 2 zip files in your nt directory which contain the
    binary distributions (full and bin only).

    > Clearly, --distfiles are only copied at packaging time?
    > ... not at `make install', for instance libXpm.dll (the only file that I
    > should be adding)?

    That's correct. libXpm.dll is the only file you need.

    If you can't get it to work, do this:

    mingw32-make install > build.log 2>&1

    This will create a file build.log in nt with all the output from
    make. Send me the file offlist and I will try to help troubleshoot
    this.

    For what it's worth, I just build and packaged the latest trunk and it
    worked fine.

    Christoph

Thank you.  I've been rushing ...

Message #97 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sean Sieger <sean.sieger <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#6602: [PATCH] make dist target for Windows
Date: Tue, 27 Jul 2010 21:38:42 -0400

    No, it is copied to a bin/ in a temporary directory, from which the
    zip file is created. Does the zip file contain libXpm.dll?

Sorry.  I keep dropping in the apartment and trying to get to this stuff
and not getting anywhere ... tomorrow, I will get it right.

Thank you for your patience and guidance.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.