GNU bug report logs - #65903
[PATCH] gnu: Make vice tunable.

Previous Next

To reply to this bug, email your comments to 65903 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: raingloom <raingloom <at> riseup.net>
To: guix-patches <at> gnu.org
Cc: 65890 <at> debbugs.gnu.org, Csepp <raingloom <at> riseup.net>
Subject: [PATCH] gnu: Make vice tunable.
Date: Wed, 13 Sep 2023 05:48:54 +0200

From: Csepp <raingloom <at> riseup.net>

* gnu/packages/emulators.scm (vice)[properties]: Set tunable? to #t.
---
This fixes the issue with unsupported AVX instructions.

 gnu/packages/emulators.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
index 1d50c9ef01..dd1e3e877f 100644
--- a/gnu/packages/emulators.scm
+++ b/gnu/packages/emulators.scm
@@ -118,6 +118,7 @@ (define-public vice
   (package
     (name "vice")
     (version "3.7.1")
+    (properties '((tunable? . #t)))
     (source
      (origin
        (method url-fetch)

base-commit: 07d43c66d5c11fef61f9846fefb97fa18e4764f1
-- 
2.41.0

Message #8 received at 65903 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: raingloom <raingloom <at> riseup.net>
Cc: 65903 <at> debbugs.gnu.org, 65890 <at> debbugs.gnu.org
Subject: Re: bug#65903: [PATCH] gnu: Make vice tunable.
Date: Thu, 14 Sep 2023 16:46:04 +0200

Hi,

raingloom <raingloom <at> riseup.net> skribis:

> From: Csepp <raingloom <at> riseup.net>
>
> * gnu/packages/emulators.scm (vice)[properties]: Set tunable? to #t.
> ---
> This fixes the issue with unsupported AVX instructions.

Could you clarify what this means, ideally as a comment above the
property?

Thanks,
Ludo’.

Message #11 received at 65903 <at> debbugs.gnu.org (full text, mbox):

From: raingloom <raingloom <at> riseup.net>
To: 65903 <at> debbugs.gnu.org
Cc: ludo <at> gnu.org, Csepp <raingloom <at> riseup.net>
Subject: [PATCH v2] gnu: Make vice tunable.
Date: Thu, 14 Sep 2023 21:47:00 +0200

From: Csepp <raingloom <at> riseup.net>

* gnu/packages/emulators.scm (vice)[properties]: Set tunable? to #t.
---
 gnu/packages/emulators.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
index 1d50c9ef01..0fb4a5853b 100644
--- a/gnu/packages/emulators.scm
+++ b/gnu/packages/emulators.scm
@@ -118,6 +118,8 @@ (define-public vice
   (package
     (name "vice")
     (version "3.7.1")
+    ;; without this it would use AVX even when it's not suported:
+    (properties '((tunable? . #t)))
     (source
      (origin
        (method url-fetch)

base-commit: 07d43c66d5c11fef61f9846fefb97fa18e4764f1
-- 
2.41.0

Message #14 received at 65903 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: raingloom <raingloom <at> riseup.net>
Cc: 65903 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: Make vice tunable.
Date: Sun, 17 Sep 2023 12:05:10 +0200

Hi,

raingloom <raingloom <at> riseup.net> skribis:

> From: Csepp <raingloom <at> riseup.net>
>
> * gnu/packages/emulators.scm (vice)[properties]: Set tunable? to #t.
> ---
>  gnu/packages/emulators.scm | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
> index 1d50c9ef01..0fb4a5853b 100644
> --- a/gnu/packages/emulators.scm
> +++ b/gnu/packages/emulators.scm
> @@ -118,6 +118,8 @@ (define-public vice
>    (package
>      (name "vice")
>      (version "3.7.1")
> +    ;; without this it would use AVX even when it's not suported:

Oh I see.  It’s a problem that ‘tunable?’ in itself doesn’t solve.

The fix would be twofold: (1) remove ‘-march’ and similar compiler
arguments that cause it to generate code that assumes AVX availability,
and (2) add the ‘tune?’ property for those who want a fine-tuned binary.

Could you look into it?

Thanks,
Ludo’.

Message #17 received at 65903 <at> debbugs.gnu.org (full text, mbox):

From: Csepp <raingloom <at> riseup.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 65903 <at> debbugs.gnu.org, raingloom <raingloom <at> riseup.net>
Subject: Re: [PATCH v2] gnu: Make vice tunable.
Date: Mon, 18 Sep 2023 14:17:25 +0200

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi,
>
> raingloom <raingloom <at> riseup.net> skribis:
>
>> From: Csepp <raingloom <at> riseup.net>
>>
>> * gnu/packages/emulators.scm (vice)[properties]: Set tunable? to #t.
>> ---
>>  gnu/packages/emulators.scm | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
>> index 1d50c9ef01..0fb4a5853b 100644
>> --- a/gnu/packages/emulators.scm
>> +++ b/gnu/packages/emulators.scm
>> @@ -118,6 +118,8 @@ (define-public vice
>>    (package
>>      (name "vice")
>>      (version "3.7.1")
>> +    ;; without this it would use AVX even when it's not suported:
>
> Oh I see.  It’s a problem that ‘tunable?’ in itself doesn’t solve.
>
> The fix would be twofold: (1) remove ‘-march’ and similar compiler
> arguments that cause it to generate code that assumes AVX availability,
> and (2) add the ‘tune?’ property for those who want a fine-tuned binary.
>
> Could you look into it?
>
> Thanks,
> Ludo’.

Umm, it definitely solved it on my machine, which doesn't have AVX.
If that's not a "proper" fix, then sure, I can try looking into it more.
But it seems to me like `tunable?` is already working as intended.

Message #20 received at 65903 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Csepp <raingloom <at> riseup.net>
Cc: 65903 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] gnu: Make vice tunable.
Date: Tue, 19 Sep 2023 11:45:44 +0200

Hi,

Csepp <raingloom <at> riseup.net> skribis:

> Ludovic Courtès <ludo <at> gnu.org> writes:

[...]

>> The fix would be twofold: (1) remove ‘-march’ and similar compiler
>> arguments that cause it to generate code that assumes AVX availability,
>> and (2) add the ‘tune?’ property for those who want a fine-tuned binary.
>>
>> Could you look into it?
>>
>> Thanks,
>> Ludo’.
>
> Umm, it definitely solved it on my machine, which doesn't have AVX.
> If that's not a "proper" fix, then sure, I can try looking into it more.
> But it seems to me like `tunable?` is already working as intended.

What I meant is that someone installing ‘vice’ without ‘--tune’ will
still get a binary that assumes AVXsomething, which may or may not work
on their machine.

The default binary (without ‘--tune’) should target baseline x86_64.

That’s why we need both fixes I mentioned above.

HTH!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.