GNU bug report logs - #65882
29.1; rcirc doesn't rejoin channels automatically on reconnecting

Previous Next

Full log

Message #58 received at 65882-done <at> debbugs.gnu.org (full text, mbox):

From: Manphiz <manphiz <at> gmail.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 65882-done <at> debbugs.gnu.org, Ryan Yeske <rcyeske <at> gmail.com>,
 Stefan Kangas <stefankangas <at> gmail.com>, Leo Liu <sdl.web <at> gmail.com>
Subject: Re: bug#65882: 29.1; rcirc doesn't rejoin channels automatically on
 reconnecting
Date: Sat, 23 Sep 2023 15:34:21 -0700

Philip Kaludercic <philipk <at> posteo.net> writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>
>> Manphiz <manphiz <at> gmail.com> writes:
>>
>>>> I don't necessarily object, but is it a regression?
>>>
>>> The reconnecting and rejoining channels feature is broken in certain
>>> situation, and this patch fixes that.  Some other users claimed this
>>> works for them, so I would say this may be considered a regression.
>>>
>>>> Is the change safe?
>>>
>>> According to the logic of the code, this patch enables doing work that
>>> (I believe) should have been done and not changing anything else, so I
>>> would say it is safe.
>>>
>>>> If the answer to either of those questions is "no", I think master is
>>>> the safer choice.
>>>
>>> I would say the answers are both yes, but of course that's just my
>>> opinion and the decision is up to you :)
>>
>> Thanks.  If Philip agrees, I see no reason why this can't be installed
>> on emacs-29.
>
> I am fine with it as well, so I'll cherry-pick the branch from master
> onto emacs-29.

Great!  Thanks everyone!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.