GNU bug report logs - #65734
29.1.50; kill-whole-line and visibility of Org subtrees

Previous Next

Full log

Message #208 received at 65734-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: yantar92 <at> posteo.net, iota <at> whxvd.name,
 Stefan Kangas <stefankangas <at> gmail.com>
Cc: acorallo <at> gnu.org, 65734-done <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8
 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)]
Date: Thu, 27 Jun 2024 11:41:22 +0300

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Sat, 22 Jun 2024 12:00:26 -0700
> Cc: iota <at> whxvd.name, monnier <at> iro.umontreal.ca, 65734 <at> debbugs.gnu.org, 
> 	Andrea Corallo <acorallo <at> gnu.org>
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> From: Ihor Radchenko <yantar92 <at> posteo.net>
> >> Cc: Sebastian Miele <iota <at> whxvd.name>, Stefan Monnier
> >>  <monnier <at> iro.umontreal.ca>, Stefan Kangas <stefankangas <at> gmail.com>,
> >>  65734 <at> debbugs.gnu.org
> >> Date: Wed, 19 Jun 2024 14:01:12 +0000
> >>
> >> Eli Zaretskii <eliz <at> gnu.org> writes:
> >>
> >> > The patches lack suitable ChangeLog-style commit log messages (see
> >> > CONTRIBUTE for details and you can use "git log" to show examples of
> >> > how we do this).
> >> >
> >> > I'd also ask Stefan Monnier and Stefan Kangas to review the patch,
> >> > since this is an important command and I would like to avoid breaking
> >> > it.
> >>
> >> Please see the attached edited patches with proper commit messages.
> >
> > Stefan, Stefan and Andrea, could you please review this?  If you see
> > no problems, let's install this in Emacs 30.
> 
> The patch and proposed behavior makes sense to me.

Thanks, I've now installed this on the emacs-30 branch, and I'm
closing the bug.

Btw, the new tests broke simple-tests (because they caused packages be
loaded that affected the completion tested by one of the tests.  I
fixed that, but please always run the relevant test files whenever you
modify them, don't assume that adding or modifying a test will never
affect other tests in the same file.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.