GNU bug report logs - #65464
Emacs 29.1 - VHDL mode missing updates…

Previous Next

Full log

Message #45 received at 65464 <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: 65464 <at> debbugs.gnu.org
Cc: Reto Zimmermann <reto <at> gnu.org>, Eli Zaretskii <eliz <at> gnu.org>,
 justafrogg <at> gmail.com, Stefan Kangas <stefankangas <at> gmail.com>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#65464: Emacs 29.1 - VHDL mode missing updates… 
Date: Sat, 2 Sep 2023 11:20:49 +0200

Reto, while you're at it you may also want to take a look at vhdl-last-word:

(defun vhdl-last-word (point)
  "If keyword at POINT is at eoi, then return (current-column) at that point.
Otherwise, return nil."
  (save-excursion
    (and (goto-char point)
	 (save-excursion (or (eq (progn (forward-sexp) (point))
				 (vhdl-point 'eoi))
			     (looking-at "\\s-*\\(--\\)?")))
	 (current-column))))

Since the calls to goto-char and looking-at never return nil, this function will always return the column of its argument. (The regexp matches the empty string so looking-at will succeed anywhere.)

And because vhdl-last-word is only used for its boolean value and never returns nil, calls to this function could effectively be replaced by t, but that was probably not the intention.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.