GNU bug report logs - #65154
vhdl-mode bug

Previous Next

Package: emacs;

Reported by: Gonzalo Larumbe <gonzalomlarumbe <at> gmail.com>

Date: Tue, 8 Aug 2023 17:57:01 UTC

Severity: normal

Merged with 65464

To reply to this bug, email your comments to 65154 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#65154; Package emacs. (Tue, 08 Aug 2023 17:57:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Gonzalo Larumbe <gonzalomlarumbe <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 08 Aug 2023 17:57:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gonzalo Larumbe <gonzalomlarumbe <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: vhdl-mode bug
Date: Tue, 8 Aug 2023 19:55:59 +0200
[Message part 1 (text/plain, inline)]
Hello,

While developing some features for `vhdl-ext` MELPA package (
https://github.com/gmlarumbe/vhdl-ext) I believe I have come across a bug
in `vhdl-mode` function `vhdl-corresponding-begin`.

Inside the cond block, for the "end component" condition, it seems that the
enclosing parentheses to set capture group 1 in the `looking-at` string
argument are missing.

I attach a simple patch that fixes it.

Thanks!

Gonzalo
[Message part 2 (text/html, inline)]
[vhdl-corresponding-begin.patch (text/x-patch, attachment)]

Added tag(s) patch. Request was from Stefan Kangas <stefankangas <at> gmail.com> to control <at> debbugs.gnu.org. (Tue, 08 Aug 2023 18:01:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#65154; Package emacs. (Wed, 23 Aug 2023 10:49:02 GMT) Full text and rfc822 format available.

Message #10 received at 65154 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Gonzalo Larumbe <gonzalomlarumbe <at> gmail.com>, Reto Zimmermann <reto <at> gnu.org>
Cc: 65154 <at> debbugs.gnu.org
Subject: Re: bug#65154: vhdl-mode bug
Date: Wed, 23 Aug 2023 12:48:29 +0200
Gonzalo Larumbe <gonzalomlarumbe <at> gmail.com> writes:

> Hello,
>
> While developing some features for `vhdl-ext` MELPA package (https://github.com/gmlarumbe/vhdl-ext) I believe I have come across a bug in `vhdl-mode` function `vhdl-corresponding-begin`.
>
> Inside the cond block, for the "end component" condition, it seems that the enclosing parentheses to set capture group 1 in the `looking-at` string argument are missing.
>
> I attach a simple patch that fixes it.
>
> Thanks!
>
> Gonzalo

Copying in vhdl-mode.el maintainer Reto Zimmermann.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#65154; Package emacs. (Tue, 29 Aug 2023 13:21:01 GMT) Full text and rfc822 format available.

Message #13 received at 65154 <at> debbugs.gnu.org (full text, mbox):

From: Reto Zimmermann <reto <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>,
 Gonzalo Larumbe <gonzalomlarumbe <at> gmail.com>
Cc: 65154 <at> debbugs.gnu.org
Subject: Re: bug#65154: vhdl-mode bug
Date: Tue, 29 Aug 2023 15:20:07 +0200
Thanks for reporting the issue.  It is fixed in my latest version 3.39.2 at

https://iis.ee.ethz.ch/~zimmi/emacs/vhdl-mode.html

Reto


On 2023-08-23 12:48, Stefan Kangas wrote:
> Gonzalo Larumbe <gonzalomlarumbe <at> gmail.com> writes:
>
>> Hello,
>>
>> While developing some features for `vhdl-ext` MELPA package (https://github.com/gmlarumbe/vhdl-ext) I believe I have come across a bug in `vhdl-mode` function `vhdl-corresponding-begin`.
>>
>> Inside the cond block, for the "end component" condition, it seems that the enclosing parentheses to set capture group 1 in the `looking-at` string argument are missing.
>>
>> I attach a simple patch that fixes it.
>>
>> Thanks!
>>
>> Gonzalo
> Copying in vhdl-mode.el maintainer Reto Zimmermann.





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#65154; Package emacs. (Tue, 29 Aug 2023 16:49:01 GMT) Full text and rfc822 format available.

Message #16 received at 65154 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Reto Zimmermann <reto <at> gnu.org>
Cc: 65154 <at> debbugs.gnu.org, Gonzalo Larumbe <gonzalomlarumbe <at> gmail.com>
Subject: Re: bug#65154: vhdl-mode bug
Date: Tue, 29 Aug 2023 18:47:55 +0200
forcemerge 65154 65464
thanks

Reto Zimmermann <reto <at> gnu.org> writes:

> Thanks for reporting the issue.  It is fixed in my latest version 3.39.2 at
>
> https://iis.ee.ethz.ch/~zimmi/emacs/vhdl-mode.html

Thanks.  I'm therefore merging this bug with Bug#65464, which is about
upgrading vhdl-mode.el in Emacs itself.




Forcibly Merged 65154 65464. Request was from Stefan Kangas <stefankangas <at> gmail.com> to control <at> debbugs.gnu.org. (Tue, 29 Aug 2023 16:49:02 GMT) Full text and rfc822 format available.

Removed tag(s) patch. Request was from Stefan Kangas <stefankangas <at> gmail.com> to control <at> debbugs.gnu.org. (Fri, 01 Sep 2023 20:23:01 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 290 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.