GNU bug report logs - #65413
[PATCH] services: mcron: Add module for %user-log-dir.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Hilton Chain <hako <at> ultrarare.space>
Subject: bug#65413: closed (Close: [PATCH] services: mcron: Add module for
 %user-log-dir.)
Date: Tue, 22 Aug 2023 12:49:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#65413: [PATCH] services: mcron: Add module for %user-log-dir.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 65413 <at> debbugs.gnu.org.

-- 
65413: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65413
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Hilton Chain <hako <at> ultrarare.space>
To: 65413-done <at> debbugs.gnu.org
Subject: Close: [PATCH] services: mcron: Add module for %user-log-dir.
Date: Tue, 22 Aug 2023 20:47:51 +0800

On Mon, 21 Aug 2023 12:33:22 +0800,
Hilton Chain wrote:
>
> * gnu/services/mcron.scm (mcron-shepherd-services)[modules]: Add
> (shepherd support) for home service.
> ---

Pushed as 552d0703776c532f25498d5cb852c3c497cb9252.

[Message part 3 (message/rfc822, inline)]

From: Hilton Chain <hako <at> ultrarare.space>
To: guix-patches <at> gnu.org
Cc: Hilton Chain <hako <at> ultrarare.space>
Subject: [PATCH] services: mcron: Add module for %user-log-dir.
Date: Mon, 21 Aug 2023 12:33:22 +0800

* gnu/services/mcron.scm (mcron-shepherd-services)[modules]: Add
(shepherd support) for home service.
---

This patch fixes the following error:
  Loading /gnu/store/...-shepherd.conf.
  herd: error: exception caught while executing 'load' on service 'root':
  Unbound variable: %user-log-dir

I wasn't fully sure to report the issue in #65119 since the error didn't occur
in a home container, sorry for my hesitation.

 gnu/services/mcron.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/services/mcron.scm b/gnu/services/mcron.scm
index db8b539ff5..efb7465549 100644
--- a/gnu/services/mcron.scm
+++ b/gnu/services/mcron.scm
@@ -165,6 +165,9 @@ (define (mcron-shepherd-services config)
                             (ice-9 popen) ;for the 'schedule' action
                             (ice-9 rdelim)
                             (ice-9 match)
+                            ,(if home-service?
+                                 '(shepherd support) ;for '%user-log-dir'
+                                 '())
                             ,@%default-modules))
                  (start #~(make-forkexec-constructor
                            (list #$(file-append mcron "/bin/mcron")

base-commit: 7cad70566322262f6acdbbb965e867e34010eb55
-- 
2.41.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.