GNU bug report logs - #65413
[PATCH] services: mcron: Add module for %user-log-dir.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65413 in the body.
You can then email your comments to 65413 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: guix-patches <at> gnu.org
Cc: Hilton Chain <hako <at> ultrarare.space>
Subject: [PATCH] services: mcron: Add module for %user-log-dir.
Date: Mon, 21 Aug 2023 12:33:22 +0800

* gnu/services/mcron.scm (mcron-shepherd-services)[modules]: Add
(shepherd support) for home service.
---

This patch fixes the following error:
  Loading /gnu/store/...-shepherd.conf.
  herd: error: exception caught while executing 'load' on service 'root':
  Unbound variable: %user-log-dir

I wasn't fully sure to report the issue in #65119 since the error didn't occur
in a home container, sorry for my hesitation.

 gnu/services/mcron.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/services/mcron.scm b/gnu/services/mcron.scm
index db8b539ff5..efb7465549 100644
--- a/gnu/services/mcron.scm
+++ b/gnu/services/mcron.scm
@@ -165,6 +165,9 @@ (define (mcron-shepherd-services config)
                             (ice-9 popen) ;for the 'schedule' action
                             (ice-9 rdelim)
                             (ice-9 match)
+                            ,(if home-service?
+                                 '(shepherd support) ;for '%user-log-dir'
+                                 '())
                             ,@%default-modules))
                  (start #~(make-forkexec-constructor
                            (list #$(file-append mcron "/bin/mcron")

base-commit: 7cad70566322262f6acdbbb965e867e34010eb55
-- 
2.41.0

Message #10 received at 65413-done <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: 65413-done <at> debbugs.gnu.org
Subject: Close: [PATCH] services: mcron: Add module for %user-log-dir.
Date: Tue, 22 Aug 2023 20:47:51 +0800

On Mon, 21 Aug 2023 12:33:22 +0800,
Hilton Chain wrote:
>
> * gnu/services/mcron.scm (mcron-shepherd-services)[modules]: Add
> (shepherd support) for home service.
> ---

Pushed as 552d0703776c532f25498d5cb852c3c497cb9252.

Message #13 received at 65413 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: 65413 <at> debbugs.gnu.org
Subject: Re: Close: [PATCH] services: mcron: Add module for %user-log-dir.
Date: Tue, 22 Aug 2023 23:21:10 +0800

On Tue, 22 Aug 2023 20:47:51 +0800,
Hilton Chain wrote:
> 
> On Mon, 21 Aug 2023 12:33:22 +0800,
> Hilton Chain wrote:
> >
> > * gnu/services/mcron.scm (mcron-shepherd-services)[modules]: Add
> > (shepherd support) for home service.
> > ---
> 
> Pushed as 552d0703776c532f25498d5cb852c3c497cb9252.

Fixup pushed as 0c4fb8f43f8aba2dcabe1bc97a8f6d8d41057704...

--8<---------------cut here---------------start------------->8---
1 file changed, 1 insertion(+), 3 deletions(-)
gnu/services/mcron.scm | 4 +---

modified   gnu/services/mcron.scm
@@ -165,9 +165,7 @@ (define (mcron-shepherd-services config)
                             (ice-9 popen) ;for the 'schedule' action
                             (ice-9 rdelim)
                             (ice-9 match)
-                            ,(if home-service?
-                                 '((shepherd support) #:select (%user-log-dir))
-                                 '())
+                            ((shepherd support) #:select (%user-log-dir))
                             ,@%default-modules))
                  (start #~(make-forkexec-constructor
                            (list #$(file-append mcron "/bin/mcron")
--8<---------------cut here---------------end--------------->8---

Message #16 received at 65413 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Hilton Chain <hako <at> ultrarare.space>
Cc: 65413 <at> debbugs.gnu.org
Subject: Re: [bug#65413] [PATCH] services: mcron: Add module for %user-log-dir.
Date: Tue, 22 Aug 2023 18:11:19 +0200

Hilton Chain <hako <at> ultrarare.space> skribis:

> * gnu/services/mcron.scm (mcron-shepherd-services)[modules]: Add
> (shepherd support) for home service.
> ---
>
> This patch fixes the following error:
>   Loading /gnu/store/...-shepherd.conf.
>   herd: error: exception caught while executing 'load' on service 'root':
>   Unbound variable: %user-log-dir
>
> I wasn't fully sure to report the issue in #65119 since the error didn't occur
> in a home container, sorry for my hesitation.

I tested the changes in ‘guix home container’ and didn’t notice the
error; I wonder what’s going on, would be worth investigating.

Anyway, thanks for the quick fix!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.