GNU bug report logs - #65162
30.0.50; [PATCH] Simplify some internal Eshell command parsing functions

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Porter <jporterbugs <at> gmail.com>
Subject: bug#65162: closed (Re: bug#65162: 30.0.50; [PATCH] Simplify some
 internal Eshell command parsing functions)
Date: Thu, 10 Aug 2023 17:59:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#65162: 30.0.50; [PATCH] Simplify some internal Eshell command parsing functions

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 65162 <at> debbugs.gnu.org.

-- 
65162: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65162
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: 65162-done <at> debbugs.gnu.org
Subject: Re: bug#65162: 30.0.50; [PATCH] Simplify some internal Eshell command
 parsing functions
Date: Thu, 10 Aug 2023 10:57:55 -0700

On 8/8/2023 5:16 PM, Jim Porter wrote:
> These changes are just there for cleanup, and to make it easier to work 
> with this code going forward. Since Eshell command parsing now has 
> fairly-thorough regression tests, I think these changes should be pretty 
> safe.

Merged to master as 60090abcbc5, and closing this now.

[Message part 3 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Simplify some internal Eshell command parsing
 functions
Date: Tue, 8 Aug 2023 17:16:30 -0700

[Message part 4 (text/plain, inline)]

These changes are just there for cleanup, and to make it easier to work 
with this code going forward. Since Eshell command parsing now has 
fairly-thorough regression tests, I think these changes should be pretty 
safe.

In the second patch, I removed the need to use a dynamically-bound 
variable, but kept the old (now obsolete) function around for 
compatibility. I doubt any external packages are using this, but better 
safe than sorry...

[0001-Simplify-command-parsing-in-Eshell.patch (text/plain, attachment)]

[0002-Return-separators-from-eshell-split-commands-directl.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.