GNU bug report logs - #65162
30.0.50; [PATCH] Simplify some internal Eshell command parsing functions

Previous Next

Package: emacs;

Reported by: Jim Porter <jporterbugs <at> gmail.com>

Date: Wed, 9 Aug 2023 00:17:01 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Done: Jim Porter <jporterbugs <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65162 in the body.
You can then email your comments to 65162 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#65162; Package emacs. (Wed, 09 Aug 2023 00:17:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Jim Porter <jporterbugs <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 09 Aug 2023 00:17:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Simplify some internal Eshell command parsing
 functions
Date: Tue, 8 Aug 2023 17:16:30 -0700

[Message part 1 (text/plain, inline)]
These changes are just there for cleanup, and to make it easier to work 
with this code going forward. Since Eshell command parsing now has 
fairly-thorough regression tests, I think these changes should be pretty 
safe.

In the second patch, I removed the need to use a dynamically-bound 
variable, but kept the old (now obsolete) function around for 
compatibility. I doubt any external packages are using this, but better 
safe than sorry...
[0001-Simplify-command-parsing-in-Eshell.patch (text/plain, attachment)]
[0002-Return-separators-from-eshell-split-commands-directl.patch (text/plain, attachment)]
Reply sent to Jim Porter <jporterbugs <at> gmail.com>:
You have taken responsibility. (Thu, 10 Aug 2023 17:59:02 GMT) Full text and rfc822 format available.
Notification sent to Jim Porter <jporterbugs <at> gmail.com>:
bug acknowledged by developer. (Thu, 10 Aug 2023 17:59:03 GMT) Full text and rfc822 format available.

Message #10 received at 65162-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: 65162-done <at> debbugs.gnu.org
Subject: Re: bug#65162: 30.0.50; [PATCH] Simplify some internal Eshell command
 parsing functions
Date: Thu, 10 Aug 2023 10:57:55 -0700

On 8/8/2023 5:16 PM, Jim Porter wrote:
> These changes are just there for cleanup, and to make it easier to work 
> with this code going forward. Since Eshell command parsing now has 
> fairly-thorough regression tests, I think these changes should be pretty 
> safe.

Merged to master as 60090abcbc5, and closing this now.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 08 Sep 2023 11:24:09 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 289 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.