GNU bug report logs - #65156
29.1; Reading from pipe with --insert or insert-file-contents no longer supported

Previous Next

Full log

Message #20 received at 65156 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, Paul Eggert <eggert <at> cs.ucla.edu>,
 65156 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>,
 mail <at> lucaswerkmeister.de
Subject: Re: bug#65156: 29.1; Reading from pipe with --insert or
 insert-file-contents no longer supported
Date: Wed, 09 Aug 2023 16:15:53 +0800

Mattias Engdegård <mattias.engdegard <at> gmail.com> writes:

> The current (4767f5eaee) code on emacs-29 fails fileio-tests with:
>
> Test fileio-tests--non-regular-insert condition:
>     (ert-test-failed
>      ((should-error
>        (insert-file-contents "/dev/urandom" nil 5 10))
>       :form
>       (insert-file-contents "/dev/urandom" nil 5 10)
>       :value
>       ("/dev/urandom" 5)
>       :fail-reason "did not signal an error"))

Right, but that's a problem with the test: /dev/urandom is seekable
under the Linux kernel.  I fixed this on master by checking for a
regular file instead of a seekable file when verifying BEG, but that's
too extensive a change for Emacs 29.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.