GNU bug report logs - #6515
24.0.50; unneeded let-binded variable in bookmark.el

Previous Next

Package: emacs;

Reported by: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>

Date: Fri, 25 Jun 2010 21:40:03 UTC

Severity: normal

Found in version 24.0.50

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 6515 <at> debbugs.gnu.org (full text, mbox):

From: Christoph <cschol2112 <at> googlemail.com>
To: 6515 <at> debbugs.gnu.org
Subject: Patch for bug #6515: unneeded let-bound variables in bookmark.el
Date: Sat, 26 Jun 2010 15:45:18 -0600

[Message part 1 (text/plain, inline)]
Hi

Find attached a bugfix for bug #6515
(http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6515) for review.

Imho, the bug report is valid. I don't think the code in question should
override globally set variable bookmark-automatically-show-annotations.
Therefore, the let variables were removed.

I sent in my signed paperwork a while ago, but haven't heard anything
back, so I hope this is minor enough to maybe go through without it.

Christoph


[bugfix_6515.txt.txt (text/plain, attachment)]
This bug report was last modified 14 years and 334 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.