GNU bug report logs - #6515
24.0.50; unneeded let-binded variable in bookmark.el

Previous Next

Package: emacs;

Reported by: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>

Date: Fri, 25 Jun 2010 21:40:03 UTC

Severity: normal

Found in version 24.0.50

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6515 in the body.
You can then email your comments to 6515 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6515; Package emacs. (Fri, 25 Jun 2010 21:40:03 GMT) Full text and rfc822 format available.
Acknowledgement sent to Thierry Volpiatto <thierry.volpiatto <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 25 Jun 2010 21:40:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; unneeded let-binded variable in bookmark.el
Date: Fri, 25 Jun 2010 23:13:20 +0200

Hi,
bookmark-bmenu-switch-other-window
bookmark-bmenu-2-window
bookmark-bmenu-other-window

(let ((bookmark-automatically-show-annotations nil)) ;FIXME: needed?

Indeed it's not needed, worst, it anhile effect of global
bookmark-automatically-show-annotations

Thierry.
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6515; Package emacs. (Sat, 26 Jun 2010 21:47:02 GMT) Full text and rfc822 format available.

Message #8 received at 6515 <at> debbugs.gnu.org (full text, mbox):

From: Christoph <cschol2112 <at> googlemail.com>
To: 6515 <at> debbugs.gnu.org
Subject: Patch for bug #6515: unneeded let-bound variables in bookmark.el
Date: Sat, 26 Jun 2010 15:45:18 -0600

[Message part 1 (text/plain, inline)]
Hi

Find attached a bugfix for bug #6515
(http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6515) for review.

Imho, the bug report is valid. I don't think the code in question should
override globally set variable bookmark-automatically-show-annotations.
Therefore, the let variables were removed.

I sent in my signed paperwork a while ago, but haven't heard anything
back, so I hope this is minor enough to maybe go through without it.

Christoph


[bugfix_6515.txt.txt (text/plain, attachment)]
Reply sent to Chong Yidong <cyd <at> stupidchicken.com>:
You have taken responsibility. (Sun, 27 Jun 2010 18:05:02 GMT) Full text and rfc822 format available.
Notification sent to Thierry Volpiatto <thierry.volpiatto <at> gmail.com>:
bug acknowledged by developer. (Sun, 27 Jun 2010 18:05:02 GMT) Full text and rfc822 format available.

Message #13 received at 6515-done <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Christoph <cschol2112 <at> googlemail.com>
Cc: 6515-done <at> debbugs.gnu.org, Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Subject: Re: 24.0.50; unneeded let-binded variable in bookmark.el
Date: Sun, 27 Jun 2010 14:04:54 -0400

> Find attached a bugfix for bug #6515
> (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6515) for review.
>
> Imho, the bug report is valid. I don't think the code in question should
> override globally set variable bookmark-automatically-show-annotations.
> Therefore, the let variables were removed.

Yes, checked in, thanks.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 26 Jul 2010 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 14 years and 333 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.