GNU bug report logs - #6515
24.0.50; unneeded let-binded variable in bookmark.el

Previous Next

Package: emacs;

Reported by: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>

Date: Fri, 25 Jun 2010 21:40:03 UTC

Severity: normal

Found in version 24.0.50

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#6515: closed (24.0.50; unneeded let-binded variable in
 bookmark.el)
Date: Sun, 27 Jun 2010 18:05:02 +0000

[Message part 1 (text/plain, inline)]
Your message dated Sun, 27 Jun 2010 14:04:54 -0400
with message-id <87wrtk2vy1.fsf <at> stupidchicken.com>
and subject line Re: 24.0.50; unneeded let-binded variable in bookmark.el
has caused the GNU bug report #6515,
regarding 24.0.50; unneeded let-binded variable in bookmark.el
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
6515: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6515
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]
From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; unneeded let-binded variable in bookmark.el
Date: Fri, 25 Jun 2010 23:13:20 +0200

Hi,
bookmark-bmenu-switch-other-window
bookmark-bmenu-2-window
bookmark-bmenu-other-window

(let ((bookmark-automatically-show-annotations nil)) ;FIXME: needed?

Indeed it's not needed, worst, it anhile effect of global
bookmark-automatically-show-annotations

Thierry.



[Message part 3 (message/rfc822, inline)]
From: Chong Yidong <cyd <at> stupidchicken.com>
To: Christoph <cschol2112 <at> googlemail.com>
Cc: 6515-done <at> debbugs.gnu.org, Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Subject: Re: 24.0.50; unneeded let-binded variable in bookmark.el
Date: Sun, 27 Jun 2010 14:04:54 -0400

> Find attached a bugfix for bug #6515
> (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6515) for review.
>
> Imho, the bug report is valid. I don't think the code in question should
> override globally set variable bookmark-automatically-show-annotations.
> Therefore, the let variables were removed.

Yes, checked in, thanks.
This bug report was last modified 14 years and 334 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.