GNU bug report logs - #65126
[PATCH] gnu: exiv2: Get rid of reference to GCC.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: 宋文武 <iyzsong <at> envs.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#65126: closed ([PATCH] gnu: exiv2: Get rid of reference to GCC.)
Date: Fri, 20 Oct 2023 09:59:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 20 Oct 2023 17:59:15 +0800
with message-id <87y1fx8vik.fsf <at> envs.net>
and subject line Re: [bug#65126] [PATCH] gnu: exiv2: Get rid of reference to GCC.
has caused the debbugs.gnu.org bug report #65126,
regarding [PATCH] gnu: exiv2: Get rid of reference to GCC.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
65126: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65126
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: iyzsong <at> envs.net
To: guix-patches <at> gnu.org
Cc: 宋文武 <iyzsong <at> member.fsf.org>
Subject: [PATCH] gnu: exiv2: Get rid of reference to GCC.
Date: Mon,  7 Aug 2023 22:03:03 +0800

From: 宋文武 <iyzsong <at> member.fsf.org>

This fixes <https://issues.guix.gnu.org/57677>.

* gnu/packages/image.scm (exiv2)[arguments]: Add phase to
remove _GLIBCXX_ASSERTIONS from compiler flags.
---
 gnu/packages/image.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 3336e38852..1dbf3cbdd6 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -1511,6 +1511,12 @@ (define-public exiv2
                                "-DEXIV2_ENABLE_BMFF=ON")
        #:phases
        (modify-phases %standard-phases
+         (add-after 'unpack 'patch-gcc-reference
+           (lambda _
+             ;; _GLIBCXX_ASSERTIONS brings reference to GCC.
+             (substitute* "cmake/compilerFlags.cmake"
+               (("add_compile_options[(]-Wp,-D_GLIBCXX_ASSERTIONS[)]")
+                ""))))
          (add-after 'install 'delete-static-libraries
            (lambda* (#:key outputs #:allow-other-keys)
              (let* ((out (assoc-ref outputs "out"))

base-commit: 56667ee55cd7f3368cbff169352fe440f4f93da5
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: 宋文武 <iyzsong <at> envs.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 宋文武 <iyzsong <at> member.fsf.org>,
 65126-done <at> debbugs.gnu.org
Subject: Re: [bug#65126] [PATCH] gnu: exiv2: Get rid of reference to GCC.
Date: Fri, 20 Oct 2023 17:59:15 +0800

Ludovic Courtès <ludo <at> gnu.org> writes:

> Hi 宋文武,
>
> Ludovic Courtès <ludo <at> gnu.org> skribis:
>
>> Ludovic Courtès <ludo <at> gnu.org> skribis:
>>
>>> So… LGTM!
>>
>> Well, wait for <https://qa.guix.gnu.org/issue/65126> to be done.
>
> Looks like it’s all green now, go ahead! :-)

Pushed now, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.