GNU bug report logs - #65125
[PATCH] gnu: ntp: Fix cross-compilation inputs.

Previous Next

Package: guix-patches;

Reported by: Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>

Date: Mon, 7 Aug 2023 12:19:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65125 in the body.
You can then email your comments to 65125 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#65125; Package guix-patches. (Mon, 07 Aug 2023 12:19:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 07 Aug 2023 12:19:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>
To: guix-patches <at> gnu.org
Cc: Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>
Subject: [PATCH] gnu: ntp: Fix cross-compilation inputs.
Date: Mon,  7 Aug 2023 14:17:49 +0200

* gnu/packages/ntp.scm (ntp)[inputs]: Use `target-linux?' instead of
  the manual string comparison as it would not add the libcap input
  correctly when cross-compiling as the platform ends in `-linux-gnu'
  unlike the system string which ends in `-linux'.

Signed-off-by: Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>
---
 gnu/packages/ntp.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/ntp.scm b/gnu/packages/ntp.scm
index 1a72efbc79..4ab8ab6631 100644
--- a/gnu/packages/ntp.scm
+++ b/gnu/packages/ntp.scm
@@ -139,8 +139,7 @@ (define-public ntp
            libevent
            ;; Build with POSIX capabilities support on GNU/Linux.  This allows
            ;; 'ntpd' to run as non-root (when invoked with '-u'.)
-           (if (string-suffix? "-linux"
-                               (or (%current-target-system) (%current-system)))
+           (if (target-linux?)
                (list libcap)
                '())))
    (arguments
-- 
2.34.1
Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Sat, 12 Aug 2023 20:32:01 GMT) Full text and rfc822 format available.
Notification sent to Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>:
bug acknowledged by developer. (Sat, 12 Aug 2023 20:32:02 GMT) Full text and rfc822 format available.

Message #10 received at 65125-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>
Cc: 65125-done <at> debbugs.gnu.org
Subject: Re: bug#65125: [PATCH] gnu: ntp: Fix cross-compilation inputs.
Date: Sat, 12 Aug 2023 22:30:52 +0200

Hi,

Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com> skribis:

> * gnu/packages/ntp.scm (ntp)[inputs]: Use `target-linux?' instead of
>   the manual string comparison as it would not add the libcap input
>   correctly when cross-compiling as the platform ends in `-linux-gnu'
>   unlike the system string which ends in `-linux'.

Applied, thanks!

Ludo’.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 10 Sep 2023 11:24:09 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 287 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.