GNU bug report logs - #65125
[PATCH] gnu: ntp: Fix cross-compilation inputs.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>
Subject: bug#65125: closed (Re: bug#65125: [PATCH] gnu: ntp: Fix
 cross-compilation inputs.)
Date: Sat, 12 Aug 2023 20:32:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#65125: [PATCH] gnu: ntp: Fix cross-compilation inputs.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 65125 <at> debbugs.gnu.org.

-- 
65125: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=65125
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>
Cc: 65125-done <at> debbugs.gnu.org
Subject: Re: bug#65125: [PATCH] gnu: ntp: Fix cross-compilation inputs.
Date: Sat, 12 Aug 2023 22:30:52 +0200

Hi,

Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com> skribis:

> * gnu/packages/ntp.scm (ntp)[inputs]: Use `target-linux?' instead of
>   the manual string comparison as it would not add the libcap input
>   correctly when cross-compiling as the platform ends in `-linux-gnu'
>   unlike the system string which ends in `-linux'.

Applied, thanks!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>
To: guix-patches <at> gnu.org
Cc: Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>
Subject: [PATCH] gnu: ntp: Fix cross-compilation inputs.
Date: Mon,  7 Aug 2023 14:17:49 +0200

* gnu/packages/ntp.scm (ntp)[inputs]: Use `target-linux?' instead of
  the manual string comparison as it would not add the libcap input
  correctly when cross-compiling as the platform ends in `-linux-gnu'
  unlike the system string which ends in `-linux'.

Signed-off-by: Jean-Pierre De Jesus DIAZ <jean <at> foundationdevices.com>
---
 gnu/packages/ntp.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/ntp.scm b/gnu/packages/ntp.scm
index 1a72efbc79..4ab8ab6631 100644
--- a/gnu/packages/ntp.scm
+++ b/gnu/packages/ntp.scm
@@ -139,8 +139,7 @@ (define-public ntp
            libevent
            ;; Build with POSIX capabilities support on GNU/Linux.  This allows
            ;; 'ntpd' to run as non-root (when invoked with '-u'.)
-           (if (string-suffix? "-linux"
-                               (or (%current-target-system) (%current-system)))
+           (if (target-linux?)
                (list libcap)
                '())))
    (arguments
-- 
2.34.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.