GNU bug report logs - #65121
30.0.50; Text ``icons'' in margins receive region face

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65121 in the body.
You can then email your comments to 65121 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; Text ``icons'' in margins receive region face
Date: Mon, 07 Aug 2023 16:55:53 +0800

Open emacs -nw (or on MS-DOS, just emacs.exe); then, type:

 C-h n C-x h

observe that the text representing icons within the left margin is also
highlighted.  Now, move the mouse over a link on a line that contains
such an icon: the mouse face will be displayed one column to the left of
its proper location.

Message #8 received at 65121 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 65121 <at> debbugs.gnu.org
Subject: Re: bug#65121: 30.0.50; Text ``icons'' in margins receive region face
Date: Mon, 07 Aug 2023 15:57:37 +0300

> Date: Mon, 07 Aug 2023 16:55:53 +0800
> From:  Po Lu via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Open emacs -nw (or on MS-DOS, just emacs.exe); then, type:
> 
>  C-h n C-x h
> 
> observe that the text representing icons within the left margin is also
> highlighted.

I see this, both on GNU/Linux and on MS-Windows in the -nw session,
but I don't think this is a bug.

> Now, move the mouse over a link on a line that contains such an
> icon: the mouse face will be displayed one column to the left of its
> proper location.

This I cannot reproduce on MS-Windows.  (I don't have a GNU/Linux
system with a mouse-capable TTY, so I cannot try there.)  Or maybe I
don't understand what you mean by "link on a line that contains such
an icon"?  By "links" do you mean symbols quoted 'like this'?

Strangely, not all of the links are highlighted with mouse-face, only
some.  And I cannot understand what makes different instances of a
link behave differently.

Message #11 received at 65121 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 65121 <at> debbugs.gnu.org
Subject: Re: bug#65121: 30.0.50; Text ``icons'' in margins receive region face
Date: Mon, 07 Aug 2023 21:04:09 +0800

Eli Zaretskii <eliz <at> gnu.org> writes:

> I see this, both on GNU/Linux and on MS-Windows in the -nw session,
> but I don't think this is a bug.

This doesn't happen on X frames.

> This I cannot reproduce on MS-Windows.  (I don't have a GNU/Linux
> system with a mouse-capable TTY, so I cannot try there.)  Or maybe I
> don't understand what you mean by "link on a line that contains such
> an icon"?  By "links" do you mean symbols quoted 'like this'?

Yes.  Perhaps this bug is specific to the MS-DOS build; msdos.c's
variant of tty_draw_row_with_mouse_face seems to lack special treatment
for the margin area that is present in term.c.

> Strangely, not all of the links are highlighted with mouse-face, only
> some.  And I cannot understand what makes different instances of a
> link behave differently.

Or maybe we are witnessing different manifestations of the same bug.

Thanks.

Message #14 received at 65121 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 65121 <at> debbugs.gnu.org
Subject: Re: bug#65121: 30.0.50; Text ``icons'' in margins receive region face
Date: Mon, 07 Aug 2023 16:17:37 +0300

> From: Po Lu <luangruo <at> yahoo.com>
> Cc: 65121 <at> debbugs.gnu.org
> Date: Mon, 07 Aug 2023 21:04:09 +0800
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > I see this, both on GNU/Linux and on MS-Windows in the -nw session,
> > but I don't think this is a bug.
> 
> This doesn't happen on X frames.

It does if you customize icon-preferences to use only 'text'.  The
default icon on GUI frames is an SVG image, which defines its own
background color, so the region-face background doesn't show.

> > This I cannot reproduce on MS-Windows.  (I don't have a GNU/Linux
> > system with a mouse-capable TTY, so I cannot try there.)  Or maybe I
> > don't understand what you mean by "link on a line that contains such
> > an icon"?  By "links" do you mean symbols quoted 'like this'?
> 
> Yes.  Perhaps this bug is specific to the MS-DOS build; msdos.c's
> variant of tty_draw_row_with_mouse_face seems to lack special treatment
> for the margin area that is present in term.c.

Could be.  Patches welcome.

> > Strangely, not all of the links are highlighted with mouse-face, only
> > some.  And I cannot understand what makes different instances of a
> > link behave differently.
> 
> Or maybe we are witnessing different manifestations of the same bug.

You mean, you see all of 'quoted' symbols show as links on GUI frames?

Message #19 received at 65121-done <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 65121-done <at> debbugs.gnu.org
Subject: Re: bug#65121: 30.0.50; Text ``icons'' in margins receive region face
Date: Mon, 07 Aug 2023 21:21:56 +0800

Eli Zaretskii <eliz <at> gnu.org> writes:

> It does if you customize icon-preferences to use only 'text'.  The
> default icon on GUI frames is an SVG image, which defines its own
> background color, so the region-face background doesn't show.

Considering this, and that:

> Could be.  Patches welcome.

I just installed a fix for this, I'm closing this bug.  Thanks for
shedding light on this.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.