GNU bug report logs - #65113
Emacs-29 and master csharp-mode with broken treesit

Previous Next

Package: emacs;

Reported by: J M <jean <at> tbm.email>

Date: Sun, 6 Aug 2023 15:05:02 UTC

Severity: normal

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: jean <at> tbm.email, Theodor Thornhill <theo <at> thornhill.no>
Cc: casouri <at> gmail.com, 65113 <at> debbugs.gnu.org
Subject: bug#65113: Emacs-29 and master csharp-mode with broken treesit
Date: Thu, 10 Aug 2023 12:05:51 +0300
> Date: Mon, 07 Aug 2023 07:46:05 +0200
> From: Theodor Thornhill <theo <at> thornhill.no>
> CC: 65113 <at> debbugs.gnu.org

Ping!  Can we please have a patch that is backward-compatible?

> On 6 August 2023 17:36:47 CEST, Eli Zaretskii <eliz <at> gnu.org> wrote:
> >> From: J M <jean <at> tbm.email>
> >> Date: Sun, 6 Aug 2023 16:03:45 +0100
> >> 
> >> Treesit is broken for csharp-mode in the latest version in master and emacs-29 and therefore does not provide syntax highlighting. 
> >> 
> >> The latest grammar repository (https://github.com/tree-sitter/tree-sitter-c-sharp) has removed the keyword void_keyword.
> >> 
> >> Please see attached the patch to resolve the issue.
> >
> >Thanks, but your patch will not work with the older version of the
> >grammar library, right?  Is it possible to make a patch that will work
> >with both?  Wed cannot rely on users having the latest grammar
> >versions, so a backward-compatible change is much more preferable.
> 
> We've had some similar patches lately that you can use for inspiration.
> 
> Thanks,
> Theo
> 




This bug report was last modified 1 year and 287 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.