GNU bug report logs - #65044
[PATCH] gnu: alacritty: Install example configuration.

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: 65044 <at> debbugs.gnu.org
Subject: [bug#65044] [PATCH] gnu: alacritty: Install example configuration.
Date: Thu, 17 Aug 2023 17:51:19 +0200

Hi,

John Kehayias <john.kehayias <at> protonmail.com> skribis:

> From 08831e7530a1c5ef6b87e293051c4b92f10d1513 Mon Sep 17 00:00:00 2001
> Message-ID: <08831e7530a1c5ef6b87e293051c4b92f10d1513.1691093041.git.john.kehayias <at> protonmail.com>
> From: John Kehayias <john.kehayias <at> protonmail.com>
> Date: Thu, 3 Aug 2023 15:54:52 -0400
> Subject: [PATCH] gnu: alacritty: Install example configuration.
>
> * gnu/packages/terminals.scm (alacritty)[phases]{install}: Install example
> configuration.
> ---
>  gnu/packages/terminals.scm | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm
> index 081ef19af1..d54910bce7 100644
> --- a/gnu/packages/terminals.scm
> +++ b/gnu/packages/terminals.scm
> @@ -1515,6 +1515,9 @@ (define-public alacritty
>                 (mkdir-p man)
>                 (copy-file "extra/alacritty.man"
>                            (string-append man "/alacritty.1"))
> +               ;; Install example configuration.
> +               (install-file "alacritty.yml"
> +                             (string-append share "/doc/alacritty-" ,version "/example"))

Nitpick: ,(package-version this-package)

That means it will pick the right version string when inheriting, as in:

  (package
    (inherit alacritty)
    (version "42.0")
    …)

Otherwise LGTM, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.