GNU bug report logs - #65044
[PATCH] gnu: alacritty: Install example configuration.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 65044 in the body.
You can then email your comments to 65044 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: alacritty: Install example configuration.
Date: Thu, 03 Aug 2023 20:07:05 +0000

[Message part 1 (text/plain, inline)]

Hi guix,

A quick simple patch to include alacritty's example configuration file as part of docs (I followed e.g. Arch's packaging putting it there rather than e.g. /etc). I wasn't sure the style of copy-file vs install-file and this custom install phase so went with what seemed cleanest. Tested it builds locally.

John

[0001-gnu-alacritty-Install-example-configuration.patch (text/x-patch, attachment)]

Message #8 received at 65044 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: 65044 <at> debbugs.gnu.org
Subject: Re: bug#65044: [PATCH] gnu: alacritty: Install example configuration.
Date: Thu, 17 Aug 2023 17:51:19 +0200

Hi,

John Kehayias <john.kehayias <at> protonmail.com> skribis:

> From 08831e7530a1c5ef6b87e293051c4b92f10d1513 Mon Sep 17 00:00:00 2001
> Message-ID: <08831e7530a1c5ef6b87e293051c4b92f10d1513.1691093041.git.john.kehayias <at> protonmail.com>
> From: John Kehayias <john.kehayias <at> protonmail.com>
> Date: Thu, 3 Aug 2023 15:54:52 -0400
> Subject: [PATCH] gnu: alacritty: Install example configuration.
>
> * gnu/packages/terminals.scm (alacritty)[phases]{install}: Install example
> configuration.
> ---
>  gnu/packages/terminals.scm | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm
> index 081ef19af1..d54910bce7 100644
> --- a/gnu/packages/terminals.scm
> +++ b/gnu/packages/terminals.scm
> @@ -1515,6 +1515,9 @@ (define-public alacritty
>                 (mkdir-p man)
>                 (copy-file "extra/alacritty.man"
>                            (string-append man "/alacritty.1"))
> +               ;; Install example configuration.
> +               (install-file "alacritty.yml"
> +                             (string-append share "/doc/alacritty-" ,version "/example"))

Nitpick: ,(package-version this-package)

That means it will pick the right version string when inheriting, as in:

  (package
    (inherit alacritty)
    (version "42.0")
    …)

Otherwise LGTM, thanks!

Ludo’.

Message #13 received at 65044-done <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 65044-done <at> debbugs.gnu.org
Subject: Re: bug#65044: [PATCH] gnu: alacritty: Install example configuration.
Date: Fri, 18 Aug 2023 15:50:32 +0000

Hello,

On Thu, Aug 17, 2023 at 05:51 PM, Ludovic Courtès wrote:

> Hi,
>
> John Kehayias <john.kehayias <at> protonmail.com> skribis:
>
>> From 08831e7530a1c5ef6b87e293051c4b92f10d1513 Mon Sep 17 00:00:00 2001
>> Message-ID: <08831e7530a1c5ef6b87e293051c4b92f10d1513.1691093041.git.john.kehayias <at> protonmail.com>
>> From: John Kehayias <john.kehayias <at> protonmail.com>
>> Date: Thu, 3 Aug 2023 15:54:52 -0400
>> Subject: [PATCH] gnu: alacritty: Install example configuration.
>>
>> * gnu/packages/terminals.scm (alacritty)[phases]{install}: Install example
>> configuration.
>> ---
>>  gnu/packages/terminals.scm | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm
>> index 081ef19af1..d54910bce7 100644
>> --- a/gnu/packages/terminals.scm
>> +++ b/gnu/packages/terminals.scm
>> @@ -1515,6 +1515,9 @@ (define-public alacritty
>>                 (mkdir-p man)
>>                 (copy-file "extra/alacritty.man"
>>                            (string-append man "/alacritty.1"))
>> +               ;; Install example configuration.
>> +               (install-file "alacritty.yml"
>> +                             (string-append share "/doc/alacritty-" ,version "/example"))
>
> Nitpick: ,(package-version this-package)
>
> That means it will pick the right version string when inheriting, as in:
>
>   (package
>     (inherit alacritty)
>     (version "42.0")
>     …)
>

Good point, thanks.

> Otherwise LGTM, thanks!
>

Made the change and pushed as d1c811268d130041b5af1ba8f8b41cdafe8f08b5 (and followed up with another commit to update source and home-page URLs as guix lint noted a redirect.)

John

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.