GNU bug report logs - #64964
[PATCH] Handle tabs in the SQL shown in the column listing

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#64964: closed ([PATCH] Handle tabs in the SQL shown in the
 column listing)
Date: Thu, 03 Aug 2023 08:50:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 03 Aug 2023 11:49:06 +0300
with message-id <83h6pgy0hp.fsf <at> gnu.org>
and subject line Re: bug#64964: [PATCH] Handle tabs in the SQL shown in the column listing
has caused the debbugs.gnu.org bug report #64964,
regarding [PATCH] Handle tabs in the SQL shown in the column listing
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
64964: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64964
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: john muhl <jm <at> pub.pink>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Handle tabs in the SQL shown in the column listing
Date: Sun, 30 Jul 2023 13:48:20 -0500

[Message part 3 (text/plain, inline)]

Tags: patch

In sqlite-mode if the SQL used to create a column used tabs then the
hide part of list columns would not remove anything after the first tab.

M-x sqlite-mode-open-file my.db

Table Name      Number of Rows  
images                        0 
users                         0

With point on ‘images’ execute sqlite-mode-list-columns (or press c)

Table Name      Number of Rows  
images                        0 
  id INTEGER PRIMARY KEY AUTOINCREMENT
  user_id INTEGER
  FOREIGN KEY (user_id) REFERENCES users (id)
		ON DELETE CASCADE
users                         0

There are two tab characters before ‘ON DELETE’. Press c again and it
collapses to:

Table Name      Number of Rows  
images                        0 
		ON DELETE CASCADE
users                         0

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.17.8) of 2023-07-28 built on localhost
Repository revision: febf4889d196895b07b3278cfac3f8ccb6a34235
Repository branch: jm/lua-ts-mode
System Description: Fedora Linux 38 (Workstation Edition)

Configured using:
 'configure --with-native-compilation=aot --with-pgtk'

[0001-Handle-tabs-in-the-SQL-shown-in-the-column-listing.patch (text/patch, attachment)]

[Message part 5 (text/plain, inline)]

[signature.asc (application/pgp-signature, inline)]

[Message part 7 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: john muhl <jm <at> pub.pink>
Cc: 64964-done <at> debbugs.gnu.org
Subject: Re: bug#64964: [PATCH] Handle tabs in the SQL shown in the column
 listing
Date: Thu, 03 Aug 2023 11:49:06 +0300

> Date: Sun, 30 Jul 2023 13:48:20 -0500
> From:  john muhl via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> In sqlite-mode if the SQL used to create a column used tabs then the
> hide part of list columns would not remove anything after the first tab.
> 
> M-x sqlite-mode-open-file my.db
> 
> Table Name      Number of Rows  
> images                        0 
> users                         0
> 
> With point on ‘images’ execute sqlite-mode-list-columns (or press c)
> 
> Table Name      Number of Rows  
> images                        0 
>   id INTEGER PRIMARY KEY AUTOINCREMENT
>   user_id INTEGER
>   FOREIGN KEY (user_id) REFERENCES users (id)
> 		ON DELETE CASCADE
> users                         0
> 
> There are two tab characters before ‘ON DELETE’. Press c again and it
> collapses to:
> 
> Table Name      Number of Rows  
> images                        0 
> 		ON DELETE CASCADE
> users                         0

Thanks, I installed your patch on the emacs-29 branch, and I'm
therefore closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.