GNU bug report logs - #64964
[PATCH] Handle tabs in the SQL shown in the column listing

Previous Next

Package: emacs;

Reported by: john muhl <jm <at> pub.pink>

Date: Sun, 30 Jul 2023 19:20:02 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64964 in the body.
You can then email your comments to 64964 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#64964; Package emacs. (Sun, 30 Jul 2023 19:20:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to john muhl <jm <at> pub.pink>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 30 Jul 2023 19:20:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Handle tabs in the SQL shown in the column listing
Date: Sun, 30 Jul 2023 13:48:20 -0500
[Message part 1 (text/plain, inline)]
Tags: patch

In sqlite-mode if the SQL used to create a column used tabs then the
hide part of list columns would not remove anything after the first tab.

M-x sqlite-mode-open-file my.db

Table Name      Number of Rows  
images                        0 
users                         0

With point on ‘images’ execute sqlite-mode-list-columns (or press c)

Table Name      Number of Rows  
images                        0 
  id INTEGER PRIMARY KEY AUTOINCREMENT
  user_id INTEGER
  FOREIGN KEY (user_id) REFERENCES users (id)
		ON DELETE CASCADE
users                         0

There are two tab characters before ‘ON DELETE’. Press c again and it
collapses to:

Table Name      Number of Rows  
images                        0 
		ON DELETE CASCADE
users                         0

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.17.8) of 2023-07-28 built on localhost
Repository revision: febf4889d196895b07b3278cfac3f8ccb6a34235
Repository branch: jm/lua-ts-mode
System Description: Fedora Linux 38 (Workstation Edition)

Configured using:
 'configure --with-native-compilation=aot --with-pgtk'

[0001-Handle-tabs-in-the-SQL-shown-in-the-column-listing.patch (text/patch, attachment)]
[Message part 3 (text/plain, inline)]

[signature.asc (application/pgp-signature, inline)]

Reply sent to Eli Zaretskii <eliz <at> gnu.org>:
You have taken responsibility. (Thu, 03 Aug 2023 08:50:01 GMT) Full text and rfc822 format available.

Notification sent to john muhl <jm <at> pub.pink>:
bug acknowledged by developer. (Thu, 03 Aug 2023 08:50:01 GMT) Full text and rfc822 format available.

Message #10 received at 64964-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: john muhl <jm <at> pub.pink>
Cc: 64964-done <at> debbugs.gnu.org
Subject: Re: bug#64964: [PATCH] Handle tabs in the SQL shown in the column
 listing
Date: Thu, 03 Aug 2023 11:49:06 +0300
> Date: Sun, 30 Jul 2023 13:48:20 -0500
> From:  john muhl via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> In sqlite-mode if the SQL used to create a column used tabs then the
> hide part of list columns would not remove anything after the first tab.
> 
> M-x sqlite-mode-open-file my.db
> 
> Table Name      Number of Rows  
> images                        0 
> users                         0
> 
> With point on ‘images’ execute sqlite-mode-list-columns (or press c)
> 
> Table Name      Number of Rows  
> images                        0 
>   id INTEGER PRIMARY KEY AUTOINCREMENT
>   user_id INTEGER
>   FOREIGN KEY (user_id) REFERENCES users (id)
> 		ON DELETE CASCADE
> users                         0
> 
> There are two tab characters before ‘ON DELETE’. Press c again and it
> collapses to:
> 
> Table Name      Number of Rows  
> images                        0 
> 		ON DELETE CASCADE
> users                         0

Thanks, I installed your patch on the emacs-29 branch, and I'm
therefore closing this bug.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 31 Aug 2023 11:24:09 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 290 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.