GNU bug report logs - #6494
23.2; find-lisp-object-file-name doc incorrect

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#6494: closed (23.2; find-lisp-object-file-name doc incorrect)
Date: Fri, 23 Jul 2010 01:56:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 23 Jul 2010 03:55:10 +0200
with message-id <AANLkTilpe9zqhc2lES1Im5OwFRWwixf8vOtzmxnAxxHn <at> mail.gmail.com>
and subject line Re: bug#6494: 23.2; find-lisp-object-file-name doc incorrect
has caused the GNU bug report #6494,
regarding 23.2; find-lisp-object-file-name doc incorrect
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
6494: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6494
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.2; find-lisp-object-file-name doc incorrect
Date: Tue, 22 Jun 2010 18:01:21 +0100

The doc-string of find-lisp-object-file-name regarding TYPE is
incorrect. The code says defvar or defface but the doc-string says
variable or face, one of which should be fixed. The attached patch fixes
the code.

cheers -- Leo

diff --git a/lisp/help-fns.el b/lisp/help-fns.el
index 86e9411..32470bb 100644
--- a/lisp/help-fns.el
+++ b/lisp/help-fns.el
@@ -244,7 +244,7 @@ suitable file is found, return nil."
   (let* ((autoloaded (eq (car-safe type) 'autoload))
 	 (file-name (or (and autoloaded (nth 1 type))
 			(symbol-file
-			 object (if (memq type (list 'defvar 'defface))
+			 object (if (memq type (list 'variable 'face))
 				    type
 				  'defun)))))
     (cond

[Message part 3 (message/rfc822, inline)]

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Leo <sdl.web <at> gmail.com>
Cc: 6494-done <at> debbugs.gnu.org
Subject: Re: bug#6494: 23.2; find-lisp-object-file-name doc incorrect
Date: Fri, 23 Jul 2010 03:55:10 +0200

On Tue, Jun 22, 2010 at 19:09, Leo <sdl.web <at> gmail.com> wrote:
>
> To be consistent with symbol-file, the doc-string should be fixed
> instead.

Fixed, thanks.

    Juanma

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.