GNU bug report logs - #6494
23.2; find-lisp-object-file-name doc incorrect

Previous Next

Package: emacs;

Reported by: Leo <sdl.web <at> gmail.com>

Date: Tue, 22 Jun 2010 17:02:02 UTC

Severity: minor

Found in version 23.2

Done: Juanma Barranquero <lekktu <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6494 in the body.
You can then email your comments to 6494 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6494; Package emacs. (Tue, 22 Jun 2010 17:02:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Leo <sdl.web <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 22 Jun 2010 17:02:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.2; find-lisp-object-file-name doc incorrect
Date: Tue, 22 Jun 2010 18:01:21 +0100

The doc-string of find-lisp-object-file-name regarding TYPE is
incorrect. The code says defvar or defface but the doc-string says
variable or face, one of which should be fixed. The attached patch fixes
the code.

cheers -- Leo

diff --git a/lisp/help-fns.el b/lisp/help-fns.el
index 86e9411..32470bb 100644
--- a/lisp/help-fns.el
+++ b/lisp/help-fns.el
@@ -244,7 +244,7 @@ suitable file is found, return nil."
   (let* ((autoloaded (eq (car-safe type) 'autoload))
 	 (file-name (or (and autoloaded (nth 1 type))
 			(symbol-file
-			 object (if (memq type (list 'defvar 'defface))
+			 object (if (memq type (list 'variable 'face))
 				    type
 				  'defun)))))
     (cond
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6494; Package emacs. (Tue, 22 Jun 2010 17:10:03 GMT) Full text and rfc822 format available.

Message #8 received at 6494 <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: 6494 <at> debbugs.gnu.org
Subject: Re: 23.2; find-lisp-object-file-name doc incorrect
Date: Tue, 22 Jun 2010 18:09:35 +0100

To be consistent with symbol-file, the doc-string should be fixed
instead. So ignore the patch, please.

Leo
Reply sent to Juanma Barranquero <lekktu <at> gmail.com>:
You have taken responsibility. (Fri, 23 Jul 2010 01:56:02 GMT) Full text and rfc822 format available.
Notification sent to Leo <sdl.web <at> gmail.com>:
bug acknowledged by developer. (Fri, 23 Jul 2010 01:56:02 GMT) Full text and rfc822 format available.

Message #13 received at 6494-done <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Leo <sdl.web <at> gmail.com>
Cc: 6494-done <at> debbugs.gnu.org
Subject: Re: bug#6494: 23.2; find-lisp-object-file-name doc incorrect
Date: Fri, 23 Jul 2010 03:55:10 +0200

On Tue, Jun 22, 2010 at 19:09, Leo <sdl.web <at> gmail.com> wrote:
>
> To be consistent with symbol-file, the doc-string should be fixed
> instead.

Fixed, thanks.

    Juanma
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 20 Aug 2010 11:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 14 years and 309 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.