GNU bug report logs - #64799
[PATCH] Add 'project-prompt-key' face

Previous Next

Package: emacs;

Reported by: Protesilaos Stavrou <info <at> protesilaos.com>

Date: Sun, 23 Jul 2023 08:20:02 UTC

Severity: normal

Tags: patch

Fixed in version 30.1

Done: Dmitry Gutov <dmitry <at> gutov.dev>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: Philip Kaludercic <philipk <at> posteo.net>, 64799 <at> debbugs.gnu.org, Protesilaos Stavrou <info <at> protesilaos.com>, Visuwesh <visuweshm <at> gmail.com>
Subject: bug#64799: [PATCH] Add 'project-prompt-key' face
Date: Thu, 24 Aug 2023 08:59:13 -0300
Dmitry Gutov <dmitry <at> gutov.dev> writes:

> On 23/08/2023 18:45, Visuwesh wrote:
>> [புதன் ஆகஸ்ட் 23, 2023] Dmitry Gutov wrote:
>>
>>> On 23/08/2023 18:35, Visuwesh wrote:
>>>>> Anyway, if you want the option, can you suggest how it will be 
called?
>>>>> Will it be just boolean?
>>>> A boolean option will be fine.  The facep condition can then be 
changed
>>>> to (and NEW-OPTION (facep 'help-key-binding)).
>>> Any ideas for the name?
>> project-prompt-key-use-bold-face?  I am unfortunately terrible at naming
>> things.
>
> Ok, I've added project-key-prompt-style.
>
> Please test whenever convenient.

Hi Dmitry,

> (defcustom project-key-prompt-style (if (facep 'help-key-binding)
>                                         t
>                                       'brackets)
>   "Which presentation to use when asking to choose a command by key.
>
> When `brackets', use text brackets and `bold' for the character.
> Otherwise, use the face `help-key-binding' in the prompt."
>   :type 'boolean
>   :group 'project
>   :version "30.1")

Shouldn't the :type be a choice between t and brackets?





This bug report was last modified 1 year and 334 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.