GNU bug report logs - #64800
[PATCH] Fix unstable Proced Refine Tests

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64800 in the body.
You can then email your comments to 64800 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Laurence Warne <laurencewarne <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix unstable Proced Refine Tests
Date: Sun, 23 Jul 2023 11:00:08 +0100

[Message part 1 (text/plain, inline)]

Hi, this patch fixes a couple of unstable tests for 'proced-refine' I found
whilst running tests for https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64752
yesterday.

Thanks, Laurence

[Message part 2 (text/html, inline)]

[0001-Fix-unstable-Proced-refine-tests.patch (text/x-patch, attachment)]

Message #8 received at 64800 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Laurence Warne <laurencewarne <at> gmail.com>
Cc: 64800 <at> debbugs.gnu.org
Subject: Re: bug#64800: [PATCH] Fix unstable Proced Refine Tests
Date: Sun, 23 Jul 2023 13:24:58 +0300

> From: Laurence Warne <laurencewarne <at> gmail.com>
> Date: Sun, 23 Jul 2023 11:00:08 +0100
> 
> * test/lisp/proced-tests.el (proced-refine-test)
> (proced-refine-with-update-test): Refine on session id (sess) rather
> than process id (pid) as the refiner for pid keeps processes with
> a parent process id equal to the pid refined on, which lead to
> intermittent test failures as the refine tests checked pids matched
> the pid refined on for all remaining processes.

When I run "M-x proced", I don't see "Sess" on the heading.  I do see
PID, of course.

To remind you: we selected PID because it's portable: it exists in the
Proced display on every supported platform.

Thanks.

Message #11 received at 64800 <at> debbugs.gnu.org (full text, mbox):

From: Laurence Warne <laurencewarne <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 64800 <at> debbugs.gnu.org
Subject: Re: bug#64800: [PATCH] Fix unstable Proced Refine Tests
Date: Sun, 23 Jul 2023 14:20:33 +0100

[Message part 1 (text/plain, inline)]

With non-nix systems, that's a fair point I guess session id might not be
supported (though if you're on a nix system my guess would be you're using
a proced format with session id omitted, in general the tests should guard
against this by setting the format for duration of the test).  I've
attached a new patch which makes the tests still check against PID, but
also makes the tests check if PPID matches as a fallback before failing.

Thanks, Laurence

[Message part 2 (text/html, inline)]

[0001-Fix-unstable-Proced-refine-tests.patch (text/x-patch, attachment)]

Message #16 received at 64800-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Laurence Warne <laurencewarne <at> gmail.com>
Cc: 64800-done <at> debbugs.gnu.org
Subject: Re: bug#64800: [PATCH] Fix unstable Proced Refine Tests
Date: Wed, 26 Jul 2023 17:10:57 +0300

> From: Laurence Warne <laurencewarne <at> gmail.com>
> Date: Sun, 23 Jul 2023 14:20:33 +0100
> Cc: 64800 <at> debbugs.gnu.org
> 
> With non-nix systems, that's a fair point I guess session id might not be supported (though if you're on
> a nix system my guess would be you're using a proced format with session id omitted, in general the
> tests should guard against this by setting the format for duration of the test).  I've attached a new patch
> which makes the tests still check against PID, but also makes the tests check if PPID matches as a
> fallback before failing.

Thanks, installed on the master branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.