GNU bug report logs - #64799
[PATCH] Add 'project-prompt-key' face

Previous Next

Full log

Message #47 received at 64799 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Dmitry Gutov <dmitry <at> gutov.dev>, Philip Kaludercic <philipk <at> posteo.net>
Cc: 64799 <at> debbugs.gnu.org
Subject: Re: bug#64799: [PATCH] Add 'project-prompt-key' face
Date: Fri, 28 Jul 2023 06:33:56 +0300

> From: Dmitry Gutov <dmitry <at> gutov.dev>
> Date: Thu, 27 Jul 2023 04:28:08 +0300

> [... 14 lines elided]

> The change in format seems to go hand-in-hand with the change in face, 
> though, because help-key-binding has a box already.
>
> Does this look good to everybody?
>
> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
> index d482cc24d70..3611757fb82 100644
> --- a/lisp/progmodes/project.el
> +++ b/lisp/progmodes/project.el
> @@ -1781,9 +1781,13 @@ project--keymap-prompt
>        (let ((key (if key
>                       (vector key)
>                     (where-is-internal cmd (list project-prefix-map) t))))
> -       (format "[%s] %s"
> -               (propertize (key-description key) 'face 'bold)
> -               label)))
> +       (if (facep 'help-key-binding)
> +           (format "%s %s"
> +                   (propertize (key-description key) 'face 
> 'help-key-binding)
> +                   label)
> +         (format "[%s] %s"
> +                 (propertize (key-description key) 'face 'bold)
> +                 label))))
>      project-switch-commands
>      "  "))

I am fine with this approach, thank you!

-- 
Protesilaos Stavrou
https://protesilaos.com

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.