GNU bug report logs - #64799
[PATCH] Add 'project-prompt-key' face

Previous Next

Full log

View this message in rfc822 format

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 64799 <at> debbugs.gnu.org
Subject: bug#64799: [PATCH] Add 'project-prompt-key' face
Date: Mon, 24 Jul 2023 08:53:20 +0300

> From: Philip Kaludercic <philipk <at> posteo.net>
> Date: Sun, 23 Jul 2023 13:59:41 +0000

> [... 14 lines elided]

>>> Does this even need a separate face, or shouldn't `help-key-binding' be
>>> reused directly?
>>
>> That would be my choice, though also with the removal of the square
>> brackets around it.  The proposed patch is for backward-compatibility.
>
> Backwards-compatible to what?

Just so that existing users do not complain.

> Can someone depend on this specific behaviour?

No, but the appearance still comes with certain expectations.  Plus,
there is this at the top of the file:

    ;; This is a GNU ELPA :core package.  Avoid using functionality that
    ;; not compatible with the version of Emacs recorded above

The required Emacs version is 26.1, while that of 'help-key-binding' is
28.1.

Perhaps a user option for the whole 'format' would be better?

-- 
Protesilaos Stavrou
https://protesilaos.com

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.