GNU bug report logs - #64799
[PATCH] Add 'project-prompt-key' face

Previous Next

Full log

View this message in rfc822 format

From: Philip Kaludercic <philipk <at> posteo.net>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 64799 <at> debbugs.gnu.org
Subject: bug#64799: [PATCH] Add 'project-prompt-key' face
Date: Sun, 23 Jul 2023 13:59:41 +0000

Protesilaos Stavrou <info <at> protesilaos.com> writes:

>> From: Philip Kaludercic <philipk <at> posteo.net>
>> Date: Sun, 23 Jul 2023 13:41:43 +0000
>>
>> Protesilaos Stavrou <info <at> protesilaos.com> writes:
>>
>>> Dear maintainers,
>>>
>>> I noticed that the project switching dispatch menu hardcodes its face to
>>> 'bold'.  Adding a new face here allows themes/users to customise that
>>> style (e.g. to inherit the 'help-key-binding' face).
>>
>> Does this even need a separate face, or shouldn't `help-key-binding' be
>> reused directly?
>
> That would be my choice, though also with the removal of the square
> brackets around it.  The proposed patch is for backward-compatibility.

Backwards-compatible to what?  Can someone depend on this specific
behaviour?  I think it would be better to replace the current code with
what you are suggesting, as a step towards ensuring a more consistent
user interface.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.