GNU bug report logs - #64791
30.0.50; [PATCH] Fix dired mismatch on some filenames

Previous Next

Full log

Message #62 received at 64791 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 64791 <at> debbugs.gnu.org, manuel <at> ledu-giraud.fr
Subject: Re: bug#64791: 30.0.50; [PATCH] Fix dired mismatch on some filenames
Date: Tue, 5 Sep 2023 15:27:48 -0700

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

> Actually, I take this back: this defvar will be computed when files.el
> is loaded, which is at dump time.  So this is not TRT, since the
> conditions and the environment at dump time could be very different
> from those at run time.  It could be even on another machine.

Yes, right.  That's no good.

> So I once again suggest to make this a defcustom.  This has two
> advantages:
>
>  . it will be evaluated at Emacs startup, not at dump time

Agreed.  Let's change it into a defcustom.

>  . it will allow users to customize the value and thus avoid costly
>    search  for the program and prevent finding the wrong version of
>    'ls'

Perhaps this part is okay though, given that the search should only
affect users on macOS and *BSD (who presumably will want this anyways)?

Proposed patch attached.

[0001-Make-insert-directory-program-a-defcustom-and-use-gl.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.