GNU bug report logs - #64791
30.0.50; [PATCH] Fix dired mismatch on some filenames

Previous Next

Full log

Message #41 received at 64791 <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 64791 <at> debbugs.gnu.org, Stefan Kangas <stefankangas <at> gmail.com>
Subject: Re: bug#64791: 30.0.50; [PATCH] Fix dired mismatch on some filenames
Date: Mon, 04 Sep 2023 10:05:19 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Stefan Kangas <stefankangas <at> gmail.com>
>> Date: Sun, 3 Sep 2023 11:54:07 -0700
>> Cc: manuel <at> ledu-giraud.fr, 64791 <at> debbugs.gnu.org
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> > What about making insert-directory-program a defcustom, so that people
>> > who have GNU ls under a name other than "ls" could customize that?
>> 
>> We could do that.  It wouldn't help my case unfortunately, as I'm using
>> the same config on my GNU/Linux machines as well, so I have to do the
>> whole `executable-find' thing anyway.
>> 
>> What do you think of something along these lines, which seems to work at
>> least on macOS and OpenBSD?  If you agree, we could investigate if it
>> works on FreeBSD and NetBSD too.  I *think* it will, but it's worth
>> checking to make sure.
>> 
>> diff --git a/lisp/files.el b/lisp/files.el
>> index 4188615e490..88c4ecadc9a 100644
>> --- a/lisp/files.el
>> +++ b/lisp/files.el
>> @@ -7723,7 +7723,11 @@ shell-quote-wildcard-pattern
>>        pattern))))
>> 
>> 
>> -(defvar insert-directory-program (purecopy "ls")
>> +(defvar insert-directory-program
>> +  (if (and (memq system-type '(berkeley-unix darwin))
>> +           (executable-find "gls"))
>> +      (purecopy "gls")
>> +    (purecopy "ls"))
>>    "Absolute or relative name of the `ls'-like program.
>>  This is used by `insert-directory' and `dired-insert-directory'
>>  \(thus, also by `dired').")
>
> If we believe "gls" is the only popular name, I guess that's good
> enough.

Hi,

I don't know if this count as a test but it seems that both FreeBSD and
NetBSD also called it "gls" in their respective packages:

https://cgit.freebsd.org/ports/tree/sysutils/coreutils/pkg-plist
http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/sysutils/coreutils/PLIST?rev=1.22&content-type=text/x-cvsweb-markup

But, I have to say that I still don't understand why you would not also
consider applying my patch.
-- 
Manuel Giraud

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.