GNU bug report logs - #64791
30.0.50; [PATCH] Fix dired mismatch on some filenames

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 64791 <at> debbugs.gnu.org, manuel <at> ledu-giraud.fr
Subject: bug#64791: 30.0.50; [PATCH] Fix dired mismatch on some filenames
Date: Sun, 03 Sep 2023 22:25:30 +0300

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Sun, 3 Sep 2023 11:54:07 -0700
> Cc: manuel <at> ledu-giraud.fr, 64791 <at> debbugs.gnu.org
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > What about making insert-directory-program a defcustom, so that people
> > who have GNU ls under a name other than "ls" could customize that?
> 
> We could do that.  It wouldn't help my case unfortunately, as I'm using
> the same config on my GNU/Linux machines as well, so I have to do the
> whole `executable-find' thing anyway.
> 
> What do you think of something along these lines, which seems to work at
> least on macOS and OpenBSD?  If you agree, we could investigate if it
> works on FreeBSD and NetBSD too.  I *think* it will, but it's worth
> checking to make sure.
> 
> diff --git a/lisp/files.el b/lisp/files.el
> index 4188615e490..88c4ecadc9a 100644
> --- a/lisp/files.el
> +++ b/lisp/files.el
> @@ -7723,7 +7723,11 @@ shell-quote-wildcard-pattern
>        pattern))))
> 
> 
> -(defvar insert-directory-program (purecopy "ls")
> +(defvar insert-directory-program
> +  (if (and (memq system-type '(berkeley-unix darwin))
> +           (executable-find "gls"))
> +      (purecopy "gls")
> +    (purecopy "ls"))
>    "Absolute or relative name of the `ls'-like program.
>  This is used by `insert-directory' and `dired-insert-directory'
>  \(thus, also by `dired').")

If we believe "gls" is the only popular name, I guess that's good
enough.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.