GNU bug report logs - #64717
[PATCH] Silence the compiler in vcard-parse.el from ELPA

Previous Next

Full log

Message #8 received at 64717 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Arash Esbati <arash <at> gnu.org>
Cc: 64717 <at> debbugs.gnu.org
Subject: Re: bug#64717: [PATCH] Silence the compiler in vcard-parse.el from
 ELPA
Date: Tue, 18 Jul 2023 14:59:18 -0700

Arash Esbati <arash <at> gnu.org> writes:

> X-Debbugs-CC: eric <at> ericabrahamsen.net
>
> Hi all,
>
> this is a tiny patch against vcard-parse.el in order to pacify the
> warnings about
>
>  ‘point-at-bol’ is an obsolete function ...
>  ‘point-at-eol’ is an obsolete function ...
>
>
> And while we're at: There are also
>
>   In vcard-region-decode-base64:
>   vcard.el:516:29: Warning: avoid ‘lsh’; use ‘ash’ instead
>   vcard.el:518:27: Warning: avoid ‘lsh’; use ‘ash’ instead
>   vcard.el:518:51: Warning: avoid ‘lsh’; use ‘ash’ instead
>   vcard.el:530:32: Warning: avoid ‘lsh’; use ‘ash’ instead
>
> Is `ash' a drop-in replacement?  Maybe these can be fixed as well.

Thanks for this! I've applied your patch. This stuff with base64 looks
like it it's from the year 2000, and I should follow Stefan's comments
and update it to use `base64-decode-region' directly. This is one of the
many things I'm behind on, I will try to get to it this week. Let's
leave this bug open until then.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.