GNU bug report logs - #64717
[PATCH] Silence the compiler in vcard-parse.el from ELPA

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64717 in the body.
You can then email your comments to 64717 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: emacs-bugs <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] Silence the compiler in vcard-parse.el from ELPA
Date: Tue, 18 Jul 2023 22:48:10 +0200

[Message part 1 (text/plain, inline)]

X-Debbugs-CC: eric <at> ericabrahamsen.net

Hi all,

this is a tiny patch against vcard-parse.el in order to pacify the
warnings about

 ‘point-at-bol’ is an obsolete function ...
 ‘point-at-eol’ is an obsolete function ...

[0001-vcard-parse.el-vcard-parse-buffer-Pacify-the-compile.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

And while we're at: There are also

  In vcard-region-decode-base64:
  vcard.el:516:29: Warning: avoid ‘lsh’; use ‘ash’ instead
  vcard.el:518:27: Warning: avoid ‘lsh’; use ‘ash’ instead
  vcard.el:518:51: Warning: avoid ‘lsh’; use ‘ash’ instead
  vcard.el:530:32: Warning: avoid ‘lsh’; use ‘ash’ instead

Is `ash' a drop-in replacement?  Maybe these can be fixed as well.

This is with Emacs 30.0.50 (f624b283bf).

Best, Arash

Message #8 received at 64717 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Arash Esbati <arash <at> gnu.org>
Cc: 64717 <at> debbugs.gnu.org
Subject: Re: bug#64717: [PATCH] Silence the compiler in vcard-parse.el from
 ELPA
Date: Tue, 18 Jul 2023 14:59:18 -0700

Arash Esbati <arash <at> gnu.org> writes:

> X-Debbugs-CC: eric <at> ericabrahamsen.net
>
> Hi all,
>
> this is a tiny patch against vcard-parse.el in order to pacify the
> warnings about
>
>  ‘point-at-bol’ is an obsolete function ...
>  ‘point-at-eol’ is an obsolete function ...
>
>
> And while we're at: There are also
>
>   In vcard-region-decode-base64:
>   vcard.el:516:29: Warning: avoid ‘lsh’; use ‘ash’ instead
>   vcard.el:518:27: Warning: avoid ‘lsh’; use ‘ash’ instead
>   vcard.el:518:51: Warning: avoid ‘lsh’; use ‘ash’ instead
>   vcard.el:530:32: Warning: avoid ‘lsh’; use ‘ash’ instead
>
> Is `ash' a drop-in replacement?  Maybe these can be fixed as well.

Thanks for this! I've applied your patch. This stuff with base64 looks
like it it's from the year 2000, and I should follow Stefan's comments
and update it to use `base64-decode-region' directly. This is one of the
many things I'm behind on, I will try to get to it this week. Let's
leave this bug open until then.

Message #11 received at 64717 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 64717 <at> debbugs.gnu.org
Subject: Re: bug#64717: [PATCH] Silence the compiler in vcard-parse.el from
 ELPA
Date: Wed, 19 Jul 2023 16:59:19 +0200

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> Thanks for this! I've applied your patch. This stuff with base64 looks
> like it it's from the year 2000, and I should follow Stefan's comments
> and update it to use `base64-decode-region' directly. This is one of the
> many things I'm behind on, I will try to get to it this week. Let's
> leave this bug open until then.

Thanks for installing that part.  Please feel free to close this report
whenever appropriate.

Best, Arash

Message #16 received at 64717-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Arash Esbati <arash <at> gnu.org>
Cc: Eric Abrahamsen <eric <at> ericabrahamsen.net>, 64717-done <at> debbugs.gnu.org
Subject: Re: bug#64717: [PATCH] Silence the compiler in vcard-parse.el from
 ELPA
Date: Thu, 24 Aug 2023 01:45:36 +0200

> Thanks for installing that part.  Please feel free to close this report
> whenever appropriate.

Closing this now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.