GNU bug report logs - #64642
29.0.92; Native compiler doesn't compile dynamically bound functions.

Previous Next

Full log

Message #20 received at 64642 <at> debbugs.gnu.org (full text, mbox):

From: Alan Mackenzie <acm <at> muc.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Andrea Corallo <acorallo <at> gnu.org>, 64642 <at> debbugs.gnu.org
Subject: Re: bug#64642: 29.0.92; Native compiler doesn't compile dynamically
 bound functions.
Date: Mon, 17 Jul 2023 17:43:26 +0000

Hello, Eli.

On Mon, Jul 17, 2023 at 19:06:58 +0300, Eli Zaretskii wrote:
> > From: Andrea Corallo <acorallo <at> gnu.org>
> > Cc: Eli Zaretskii <eliz <at> gnu.org>,  64642 <at> debbugs.gnu.org
> > Date: Mon, 17 Jul 2023 09:42:31 -0400

> > >> It is unlikely that this will be fixed in Emacs 29, unless the fix is
> > >> so simple that will surprise me.

> > > Here is a fix.  Its simplicity probably doesn't surprise you (Eli), but
> > > the change is entirely within one function, and a lot of the patch is
> > > just whitespace changes.

> > > There are no problems running make bootstrap or make check with patch in
> > > place.  It also solves the bug; unless there are good reasons dynamically
> > > bound functions weren't handled.  Andrea?

> > Hi Alan,

> > the fix LGTM thanks for the patch, I think we only need to add a test as
> > well to exercise this code, something like the "free-fun" test in
> > comp-tests.el.

> Alan, when the patch is ready, please install on master.

I'll do that, "ready" meaning when I've written that test suggested by
Andrea.

Thanks!

> Thanks.

-- 
Alan Mackenzie (Nuremberg, Germany).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.