GNU bug report logs - #64643
[PATCH] gnu: ghc-8.10: Fix build on i686-linux.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64643 in the body.
You can then email your comments to 64643 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: ghc-8.10: Fix build on i686-linux.
Date: Sat, 15 Jul 2023 10:39:30 +0100

As one profiling test fails very repeatedly on the bordeaux build farm, but
ghc did seem to build successfully on other machines.

* gnu/packages/haskell.scm (ghc-8.10)[arguments]: Don't run the T11627a
profiling test on i686-linux.
---
 gnu/packages/haskell.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
index 6b2c86fec4..62815efbb1 100644
--- a/gnu/packages/haskell.scm
+++ b/gnu/packages/haskell.scm
@@ -1271,8 +1271,11 @@ (define-public ghc-8.10
            ;; next rebuild. Note that they are required for GHC 8.10 and 9.2.
            #$@(if (string-prefix? "i686" (or (%current-target-system)
                                              (%current-system)))
-               #~((add-after 'skip-failing-tests-i686 'skip-failing-tests-i686-cuirass
+               #~((add-after 'skip-failing-tests-i686 'skip-more-failing-tests-i686
                     (lambda _
+                      (substitute* '("testsuite/tests/profiling/should_run/all.T")
+                        (("test\\('T11627a', \\[ ")
+                         "test('T11627a', [ when(arch('i386'), skip), "))
                       (substitute* '("testsuite/driver/testlib.py")
                         ((".*changes being made to the file will invalidate the code signature.*")
                          "")

base-commit: b5a5e4d712d0a1998995be62bb41b03955b7dcf1
prerequisite-patch-id: 3297b62c093009d94f43908e88dfc50a53ccbeac
-- 
2.41.0

Message #8 received at 64643 <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <lars <at> 6xq.net>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 64643 <at> debbugs.gnu.org
Subject: Re: [bug#64643] [PATCH] gnu: ghc-8.10: Fix build on i686-linux.
Date: Sun, 16 Jul 2023 10:29:07 +0200

Hi Christopher,

> As one profiling test fails very repeatedly on the bordeaux build farm, but
> ghc did seem to build successfully on other machines.

do you have a log file showing the failure? It’s also a pretty big
rebuild (almost 1800 packages), so maybe we can apply this change on
i386 only for now?

Cheers,
Lars

Message #11 received at 64643 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Lars-Dominik Braun <lars <at> 6xq.net>
Cc: 64643 <at> debbugs.gnu.org
Subject: Re: [bug#64643] [PATCH] gnu: ghc-8.10: Fix build on i686-linux.
Date: Sun, 16 Jul 2023 09:41:41 +0100

[Message part 1 (text/plain, inline)]

Lars-Dominik Braun <lars <at> 6xq.net> writes:

> Hi Christopher,
>
>> As one profiling test fails very repeatedly on the bordeaux build farm, but
>> ghc did seem to build successfully on other machines.
>
> do you have a log file showing the failure? It’s also a pretty big
> rebuild (almost 1800 packages), so maybe we can apply this change on
> i386 only for now?

Yep, you can click the "View build on https://bordeaux.guix.gnu.org"
links from this page [1] to find the build logs for all the failing
builds.

1: https://data.qa.guix.gnu.org/gnu/store/sp4csvzxjzzjhmyp7sfdxg3ypqpysh2a-ghc-8.10.7.drv

And yes, this patch only affects i686-linux as confirmed by [2].

2: https://qa.guix.gnu.org/issue/64643

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 64643 <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <lars <at> 6xq.net>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 64643 <at> debbugs.gnu.org
Subject: Re: [bug#64643] [PATCH] gnu: ghc-8.10: Fix build on i686-linux.
Date: Sun, 16 Jul 2023 11:03:51 +0200

Hi,

> Yep, you can click the "View build on https://bordeaux.guix.gnu.org"
> links from this page [1] to find the build logs for all the failing
> builds.
> 
> 1: https://data.qa.guix.gnu.org/gnu/store/sp4csvzxjzzjhmyp7sfdxg3ypqpysh2a-ghc-8.10.7.drv

huh, a segfault. Weird. Perhaps it’s running out of address space.

> And yes, this patch only affects i686-linux as confirmed by [2].

Ah, you’re right. I missed this patch context:

>           #$@(if (string-prefix? "i686" (or (%current-target-system)
>                                             (%current-system)))

Looks good to me then!

Cheers,
Lars

Message #19 received at 64643-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Lars-Dominik Braun <lars <at> 6xq.net>
Cc: 64643-done <at> debbugs.gnu.org
Subject: Re: [bug#64643] [PATCH] gnu: ghc-8.10: Fix build on i686-linux.
Date: Mon, 17 Jul 2023 13:58:56 +0100

[Message part 1 (text/plain, inline)]

Lars-Dominik Braun <lars <at> 6xq.net> writes:

> Hi,
>
>> Yep, you can click the "View build on https://bordeaux.guix.gnu.org"
>> links from this page [1] to find the build logs for all the failing
>> builds.
>>
>> 1: https://data.qa.guix.gnu.org/gnu/store/sp4csvzxjzzjhmyp7sfdxg3ypqpysh2a-ghc-8.10.7.drv
>
> huh, a segfault. Weird. Perhaps it’s running out of address space.
>
>> And yes, this patch only affects i686-linux as confirmed by [2].
>
> Ah, you’re right. I missed this patch context:
>
>>           #$@(if (string-prefix? "i686" (or (%current-target-system)
>>                                             (%current-system)))
>
> Looks good to me then!

Great, I've pushed this to master as
ad08f9331fee7a8e71e94b02f86f54ab3e1001a8.

There's ~2000 affected packages, but I think this is OK since at least
for the bordeaux build farm, these packages are being unblocked rather
than rebuilt, and for ci, it'll take no time at all to catch up.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.