GNU bug report logs - #64498
[PATCH] gnu: rocm: Update to 5.6.0.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#64498: closed ([PATCH] gnu: rocm: Update to 5.6.0.)
Date: Tue, 11 Jul 2023 16:27:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 11 Jul 2023 16:25:49 +0000
with message-id <87r0pe1kl3.fsf <at> protonmail.com>
and subject line Re: [PATCH] gnu: rocm: Update to 5.6.0.
has caused the debbugs.gnu.org bug report #64498,
regarding [PATCH] gnu: rocm: Update to 5.6.0.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
64498: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64498
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Cc: Lars-Dominik Braun <lars <at> 6xq.net>
Subject: [PATCH] gnu: rocm: Update to 5.6.0.
Date: Thu, 06 Jul 2023 16:32:22 +0000

[Message part 3 (text/plain, inline)]

Hi Guix and Lars (as a known ROCm user and knowledgeable about these packages),

Attached is a patch to update our rocm packages to the new release, 5.6.0. Nothing too major here in terms of packaging updates, was able to get rid of some unneeded patches and did some style updates at the same time. I also did llvm-for-rocm together in one patch/commit this time since I think it makes the most sense to include it as it should match rocm-version as well. I tested everything build locally (x86_64 only) and Darktable OpenCL works with this.

One gotcha I hit I wanted to note for future reference: rocm-comgr had lld (linker from LLVM) as an input which had worked. Until you change the order of the inputs. I guess some collision/conflict with the llvm-for-rocm used to build the package. The errors for 5.6.0 I saw were unable to link to LLVM libraries. Everything works fine removing that input.

Thanks!
John

[0001-gnu-rocm-Update-to-5.6.0.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Lars-Dominik Braun <lars <at> 6xq.net>
Cc: 64498-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: rocm: Update to 5.6.0.
Date: Tue, 11 Jul 2023 16:25:49 +0000

Hi Lars,

On Sun, Jul 09, 2023 at 08:08 PM, Lars-Dominik Braun wrote:

> Hi,
>
>> Subject: [PATCH] gnu: rocm: Update to 5.6.0.
>
> looks good to me and with the attached patch it even works on my RX 460
> (aka gfx803). It still works for you, right?
>

Yes, that was the patch I had mentioned before but I thought it didn't work for you? Or maybe something else has changed too, but glad it works! And I tested locally for myself with the additional patch and darktable-cltest still works.

I added the patch, adjusted the commit message, registered the patch, and pushed as 15f9870eb36e688fac2af37828971779b6c56916.

Thanks!

John

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.