GNU bug report logs - #64498
[PATCH] gnu: rocm: Update to 5.6.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64498 in the body.
You can then email your comments to 64498 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Cc: Lars-Dominik Braun <lars <at> 6xq.net>
Subject: [PATCH] gnu: rocm: Update to 5.6.0.
Date: Thu, 06 Jul 2023 16:32:22 +0000

[Message part 1 (text/plain, inline)]

Hi Guix and Lars (as a known ROCm user and knowledgeable about these packages),

Attached is a patch to update our rocm packages to the new release, 5.6.0. Nothing too major here in terms of packaging updates, was able to get rid of some unneeded patches and did some style updates at the same time. I also did llvm-for-rocm together in one patch/commit this time since I think it makes the most sense to include it as it should match rocm-version as well. I tested everything build locally (x86_64 only) and Darktable OpenCL works with this.

One gotcha I hit I wanted to note for future reference: rocm-comgr had lld (linker from LLVM) as an input which had worked. Until you change the order of the inputs. I guess some collision/conflict with the llvm-for-rocm used to build the package. The errors for 5.6.0 I saw were unable to link to LLVM libraries. Everything works fine removing that input.

Thanks!
John

[0001-gnu-rocm-Update-to-5.6.0.patch (text/x-patch, attachment)]

Message #8 received at 64498 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: 64498 <at> debbugs.gnu.org
Cc: Lars-Dominik Braun <lars <at> 6xq.net>
Subject: Re: bug#64498: [PATCH v2] gnu: rocm: Update to 5.6.0.
Date: Thu, 06 Jul 2023 18:54:59 +0000

[Message part 1 (text/plain, inline)]

Hello,

On Thu, Jul 06, 2023 at 04:32 PM, John Kehayias wrote:

> Hi Guix and Lars (as a known ROCm user and knowledgeable about these packages),
>
> Attached is a patch to update our rocm packages to the new release,
> 5.6.0. Nothing too major here in terms of packaging updates, was able
> to get rid of some unneeded patches and did some style updates at the
> same time. I also did llvm-for-rocm together in one patch/commit this
> time since I think it makes the most sense to include it as it should
> match rocm-version as well. I tested everything build locally (x86_64
> only) and Darktable OpenCL works with this.
>
> One gotcha I hit I wanted to note for future reference: rocm-comgr had
> lld (linker from LLVM) as an input which had worked. Until you change
> the order of the inputs. I guess some collision/conflict with the
> llvm-for-rocm used to build the package. The errors for 5.6.0 I saw
> were unable to link to LLVM libraries. Everything works fine removing
> that input.
>

Fixed a minor typo in phase name, here's v2.

[0001-gnu-rocm-Update-to-5.6.0.patch (text/x-patch, attachment)]

Message #11 received at 64498 <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <lars <at> 6xq.net>
To: John Kehayias <john.kehayias <at> protonmail.com>
Cc: 64498 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: rocm: Update to 5.6.0.
Date: Sun, 9 Jul 2023 20:08:08 +0200

[Message part 1 (text/plain, inline)]

Hi,

> Subject: [PATCH] gnu: rocm: Update to 5.6.0.

looks good to me and with the attached patch it even works on my RX 460
(aka gfx803). It still works for you, right?

Cheers,
Lars

[gfx803.diff (text/plain, attachment)]

Message #16 received at 64498-done <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Lars-Dominik Braun <lars <at> 6xq.net>
Cc: 64498-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: rocm: Update to 5.6.0.
Date: Tue, 11 Jul 2023 16:25:49 +0000

Hi Lars,

On Sun, Jul 09, 2023 at 08:08 PM, Lars-Dominik Braun wrote:

> Hi,
>
>> Subject: [PATCH] gnu: rocm: Update to 5.6.0.
>
> looks good to me and with the attached patch it even works on my RX 460
> (aka gfx803). It still works for you, right?
>

Yes, that was the patch I had mentioned before but I thought it didn't work for you? Or maybe something else has changed too, but glad it works! And I tested locally for myself with the additional patch and darktable-cltest still works.

I added the patch, adjusted the commit message, registered the patch, and pushed as 15f9870eb36e688fac2af37828971779b6c56916.

Thanks!

John

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.