GNU bug report logs - #64423
29.0.92; save-interprogram-paste-before-kill doesn't prevent streaming large selections

Previous Next

Full log

Message #142 received at 64423 <at> debbugs.gnu.org (full text, mbox):

From: sbaugh <at> catern.com
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 64423 <at> debbugs.gnu.org
Subject: Re: bug#64423: 29.0.92; save-interprogram-paste-before-kill doesn't
 prevent streaming large selections
Date: Sat, 15 Jul 2023 17:38:01 +0000 (UTC)

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Resent-To: bug-gnu-emacs <at> gnu.org
>> Cc: sbaugh <at> catern.com, 64423-done <at> debbugs.gnu.org, sbaugh <at> janestreet.com
>> Date: Sat, 15 Jul 2023 12:01:31 +0300
>> From: Eli Zaretskii <eliz <at> gnu.org>
>> 
>> > From: Po Lu <luangruo <at> yahoo.com>
>> > Cc: sbaugh <at> catern.com,  sbaugh <at> janestreet.com,  64423 <at> debbugs.gnu.org
>> > Date: Sat, 15 Jul 2023 16:33:13 +0800
>> > 
>> > Eli Zaretskii <eliz <at> gnu.org> writes:
>> > 
>> > >> From: sbaugh <at> catern.com
>> > >> Date: Thu, 13 Jul 2023 22:39:10 +0000 (UTC)
>> > >> Cc: luangruo <at> yahoo.com, sbaugh <at> janestreet.com, 64423 <at> debbugs.gnu.org
>> > >> 
>> > >> > Fine by me, but please add a comment there explaining why we do
>> > >> > that
>> > >> > on X.
>> > >> >
>> > >> > Thanks.
>> > >> 
>> > >> OK, comment added, here's the patch.
>> > >
>> > > Thanks, LGTM.  Po Lu, any objections?
>> > 
>> > None here.  Please go ahead and install it.
>> 
>> Thanks, installed on the emacs-29 branch, and closing the bug.
>
> This causes the following warning to be emitted (on master):
>
>   In kill-new:
>   simple.el:5660:38: Warning: ‘ignore-error’ condition argument should
> not be quoted: 'quit

Sorry, here's the fix:

diff --git a/lisp/simple.el b/lisp/simple.el
index 54e71e1b040..6dc08ff0eb0 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -5657,7 +5657,7 @@ kill-new
                   ;; interrupt this. If they interrupt it, we want to continue
                   ;; so we become selection owner, so this doesn't stay slow.
                   (if (eq (window-system) 'x)
-                      (ignore-error 'quit (funcall interprogram-paste-function))
+                      (ignore-error quit (funcall interprogram-paste-function))
                     (funcall interprogram-paste-function)))))
         (when interprogram-paste
           (setq interprogram-paste

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.