GNU bug report logs - #64424
[PATCH] Include a help-echo for flymake's modeline counters

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64424 in the body.
You can then email your comments to 64424 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: sbaugh <at> catern.com
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Include a help-echo for flymake's modeline counters
Date: Sun, 02 Jul 2023 16:12:06 +0000 (UTC)

[Message part 1 (text/plain, inline)]

Tags: patch


This helps clarify what each of these numbers mean.  This is inspired
by compilation-mode-line-errors which does the same.

* lisp/progmodes/flymake.el (flymake--mode-line-counter): Add
help-echo to mode line properties.


In GNU Emacs 29.0.92 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.16.0, Xaw3d scroll bars) of 2023-07-01 built on earth
Repository revision: b179926388ee76f7b3304535a7189f89bd7c7f8c
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: NixOS 22.11 (Raccoon)

Configured using:
 'configure --with-x-toolkit=lucid --with-tree-sitter CC=gcc'
 

[0001-Include-a-help-echo-for-flymake-s-modeline-counters.patch (text/patch, attachment)]

Message #8 received at 64424 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: sbaugh <at> catern.com, João Távora <joaotavora <at> gmail.com>
Cc: 64424 <at> debbugs.gnu.org
Subject: Re: bug#64424: [PATCH] Include a help-echo for flymake's modeline
 counters
Date: Sun, 02 Jul 2023 20:09:06 +0300

> From: sbaugh <at> catern.com
> Date: Sun, 02 Jul 2023 16:12:06 +0000 (UTC)
> 
> This helps clarify what each of these numbers mean.  This is inspired
> by compilation-mode-line-errors which does the same.
> 
> * lisp/progmodes/flymake.el (flymake--mode-line-counter): Add
> help-echo to mode line properties.

Thanks.

João, is this safe for the release branch?

Message #11 received at 64424 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: sbaugh <at> catern.com, 64424 <at> debbugs.gnu.org
Subject: Re: bug#64424: [PATCH] Include a help-echo for flymake's modeline
 counters
Date: Sun, 2 Jul 2023 21:54:20 +0100

[Message part 1 (text/plain, inline)]

On Sun, Jul 2, 2023, 18:08 Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: sbaugh <at> catern.com
> > Date: Sun, 02 Jul 2023 16:12:06 +0000 (UTC)
> >
> > This helps clarify what each of these numbers mean.  This is inspired
> > by compilation-mode-line-errors which does the same.
> >
> > * lisp/progmodes/flymake.el (flymake--mode-line-counter): Add
> > help-echo to mode line properties.
>
> Thanks.
>
> João, is this safe for the release branch?
>

I think so, yes. I'd like to give it a bit of testing with Eglot, which
uses its own types, but it does seem safe regardless.

João

>

[Message part 2 (text/html, inline)]

Message #16 received at 64424-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: João Távora <joaotavora <at> gmail.com>
Cc: sbaugh <at> catern.com, 64424-done <at> debbugs.gnu.org
Subject: Re: bug#64424: [PATCH] Include a help-echo for flymake's modeline
 counters
Date: Mon, 03 Jul 2023 14:21:47 +0300

> From: João Távora <joaotavora <at> gmail.com>
> Date: Sun, 2 Jul 2023 21:54:20 +0100
> Cc: sbaugh <at> catern.com, 64424 <at> debbugs.gnu.org
> 
> On Sun, Jul 2, 2023, 18:08 Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>  > From: sbaugh <at> catern.com
>  > Date: Sun, 02 Jul 2023 16:12:06 +0000 (UTC)
>  > 
>  > This helps clarify what each of these numbers mean.  This is inspired
>  > by compilation-mode-line-errors which does the same.
>  > 
>  > * lisp/progmodes/flymake.el (flymake--mode-line-counter): Add
>  > help-echo to mode line properties.
> 
>  Thanks.
> 
>  João, is this safe for the release branch?
> 
> I think so, yes. I'd like to give it a bit of testing with Eglot, which uses its own types, but it does seem
> safe regardless.

Thanks, installed on the emacs-29 branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.