GNU bug report logs - #64234
patch: Ensure that makeinfo ≥ 6.8 checks the @menu structure

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64234 in the body.
You can then email your comments to 64234 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Bruno Haible <bruno <at> clisp.org>
To: bug-diffutils <at> gnu.org
Subject: patch: Ensure that makeinfo ≥ 6.8 checks the @menu
 structure
Date: Fri, 23 Jun 2023 00:36:07 +0200

[Message part 1 (text/plain, inline)]

Makeinfo versions < 6.7 detected mistakes in the @menu structure of TeXinfo
input. Makeinfo versions ≥ 6.8 don't do this any more by default. They need
an extra option, for this validation to happen. See
<https://lists.gnu.org/archive/html/bug-texinfo/2023-06/msg00015.html>.

Since doc/diffutils.texi has a hand-written @menu, it should use this extra
option.

Here's a patch to that effect.

There are two possibilities for adding the extra option:
  - in the MAKEINFO variable, where it has an effect on both "makeinfo"
    and "makeinfo --html",
  - in the AM_MAKEINFOFLAGS variable, where it has an effect on "makeinfo"
    only.
Since some maintainers may check their documentation edits only by regenerating
the HTML-formatted documentation, the first choice is preferrable.

Tested by running
  touch doc/diffutils.texi ; (cd doc && make diffutils.info V=1)
and
  make sc_makefile_at_at_check

[0001-build-Ensure-that-makeinfo-6.8-checks-the-menu-struc.patch (text/x-patch, attachment)]

Message #10 received at 64234-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Bruno Haible <bruno <at> clisp.org>
Cc: 64234-done <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#64234: patch: Ensure that makeinfo ≥ 6.8 checks the @menu structure
Date: Sat, 24 Jun 2023 18:08:38 -0700

On Thu, Jun 22, 2023 at 4:55 PM Bruno Haible <bruno <at> clisp.org> wrote:
> Makeinfo versions < 6.7 detected mistakes in the @menu structure of TeXinfo
> input. Makeinfo versions ≥ 6.8 don't do this any more by default. They need
> an extra option, for this validation to happen. See
> <https://lists.gnu.org/archive/html/bug-texinfo/2023-06/msg00015.html>.
>
> Since doc/diffutils.texi has a hand-written @menu, it should use this extra
> option.
>
> Here's a patch to that effect.
>
> There are two possibilities for adding the extra option:
>   - in the MAKEINFO variable, where it has an effect on both "makeinfo"
>     and "makeinfo --html",
>   - in the AM_MAKEINFOFLAGS variable, where it has an effect on "makeinfo"
>     only.
> Since some maintainers may check their documentation edits only by regenerating
> the HTML-formatted documentation, the first choice is preferrable.
>
> Tested by running
>   touch doc/diffutils.texi ; (cd doc && make diffutils.info V=1)
> and
>   make sc_makefile_at_at_check

Thank you. Pushed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.