GNU bug report logs - #64233
patch: Ensure that makeinfo ≥ 6.8 checks the @menu structure

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64233 in the body.
You can then email your comments to 64233 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Bruno Haible <bruno <at> clisp.org>
To: bug-coreutils <at> gnu.org
Subject: patch: Ensure that makeinfo ≥ 6.8 checks the @menu
 structure
Date: Fri, 23 Jun 2023 00:05:55 +0200

[Message part 1 (text/plain, inline)]

Makeinfo versions < 6.7 detected mistakes in the @menu structure of TeXinfo
input. Makeinfo versions ≥ 6.8 don't do this any more by default. They need
an extra option, for this validation to happen. See
<https://lists.gnu.org/archive/html/bug-texinfo/2023-06/msg00015.html>.

Since doc/coreutils.texi has a hand-written @menu, it should use this extra
option.

Here's a patch to that effect. I checked it by running
  touch doc/coreutils.texi; make doc/coreutils.info V=1
and
  make sc_makefile_at_at_check

[0001-build-Ensure-that-makeinfo-6.8-checks-the-menu-struc.patch (text/x-patch, attachment)]

Message #10 received at 64233-done <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Bruno Haible <bruno <at> clisp.org>, 64233-done <at> debbugs.gnu.org
Subject: Re: bug#64233: patch: Ensure that makeinfo ≥ 6.8 checks the @menu structure
Date: Thu, 22 Jun 2023 23:27:51 +0100

On 22/06/2023 23:05, Bruno Haible wrote:
> Makeinfo versions < 6.7 detected mistakes in the @menu structure of TeXinfo
> input. Makeinfo versions ≥ 6.8 don't do this any more by default. They need
> an extra option, for this validation to happen. See
> <https://lists.gnu.org/archive/html/bug-texinfo/2023-06/msg00015.html>.
> 
> Since doc/coreutils.texi has a hand-written @menu, it should use this extra
> option.
> 
> Here's a patch to that effect. I checked it by running
>    touch doc/coreutils.texi; make doc/coreutils.info V=1
> and
>    make sc_makefile_at_at_check


coreutils has a dep on makeinfo >= 6.1
and that version supports the -c option,
so the change should work everywhere.

Pushed.

Marking this as done.

thanks!
Pádraig

Message #13 received at 64233-done <at> debbugs.gnu.org (full text, mbox):

From: Bruno Haible <bruno <at> clisp.org>
To: 64233-done <at> debbugs.gnu.org,
 Pádraig Brady <P <at> draigbrady.com>
Subject: Re: bug#64233: patch: Ensure that makeinfo ≥ 6.8
 checks the @menu structure
Date: Fri, 23 Jun 2023 00:42:14 +0200

Pádraig Brady wrote:
> coreutils has a dep on makeinfo >= 6.1
> and that version supports the -c option,
> so the change should work everywhere.

Yes. makeinfo versions < 6.8 give a warning that they don't know about the
customization variable CHECK_NORMAL_MENU_STRUCTURE. You can simply ignore
this warning. makeinfo version 6.8 is already pretty widely deployed, since
it was released two years ago.

Bruno

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.