GNU bug report logs - #64232
28.2; Incorrect(?) byte compilation warning about ‘ansi-color-apply-on-region’

Previous Next

Package: emacs;

Reported by: Zack Weinberg <zack <at> owlfolio.org>

Date: Thu, 22 Jun 2023 19:57:02 UTC

Severity: normal

Found in version 28.2

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log


Message #43 received at 64232-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: michael_heerdegen <at> web.de, zack <at> owlfolio.org, 64232-done <at> debbugs.gnu.org
Subject: Re: bug#64232: 28.2; Incorrect(?) byte compilation warning about
 ‘ansi-color-apply-on-region’
Date: Fri, 07 Jul 2023 12:10:41 -0400
>> > > --- a/lisp/emacs-lisp/bytecomp.el
>> > > +++ b/lisp/emacs-lisp/bytecomp.el
>> > > @@ -1128,7 +1128,8 @@ byte-compile-eval
>> > >  		     ;; we arguably should add it to b-c-noruntime-functions,
>> > >                       ;; but it's not clear it's worth the trouble
>> > >  		     ;; trying to recognize that case.
>> > > -		     (unless (get f 'function-history)
>> > > +		     (unless (or (get f 'function-history)
>> > > +                                 (assq f byte-compile-function-environment))
>> > >                         (push f byte-compile-noruntime-functions)))))))))))))
>> > 
>> > Seems appropriate (and fixes this bug).
>> > Actually with that patch the situation looks already quite ok'ish to me.
>> Please install this on master, and thanks.
> Ping!  Any reasons this was not yet installed on master?

Oops, sorry.  Pushed,


        Stefan





This bug report was last modified 1 year and 323 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.