GNU bug report logs - #64203
[PATCH] guix: node-build-system: Delete from peerDependencies too.

Previous Next

Full log

Message #8 received at 64203 <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Lars-Dominik Braun <lars <at> 6xq.net>, 64203 <at> debbugs.gnu.org
Subject: Re: [bug#64203] [PATCH] guix: node-build-system: Delete from
 peerDependencies too.
Date: Thu, 22 Jun 2023 11:29:46 +0200

Lars-Dominik Braun <lars <at> 6xq.net> writes:

> * guix/build/node-build-system.scm (delete-dependencies): Remove supplied
> dependencies from peerDependencies field too.
> ---
>
> Hi,
>
> this is required to build a new RStudio. I’m also validating it does
> not break anything here: https://ci.guix.gnu.org/jobset/node-peerdeps

LGTM. You can consider adding a note to the commit message that thix
needed due to a change in how more recent npm versions deal with
peerDependencies.

Cheers,
- Jelle

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.