GNU bug report logs - #64203
[PATCH] guix: node-build-system: Delete from peerDependencies too.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64203 in the body.
You can then email your comments to 64203 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <lars <at> 6xq.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] guix: node-build-system: Delete from peerDependencies too.
Date: Wed, 21 Jun 2023 10:38:17 +0200

* guix/build/node-build-system.scm (delete-dependencies): Remove supplied
dependencies from peerDependencies field too.
---

Hi,

this is required to build a new RStudio. I’m also validating it does
not break anything here: https://ci.guix.gnu.org/jobset/node-peerdeps

Cheers,
Lars

 guix/build/node-build-system.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/guix/build/node-build-system.scm b/guix/build/node-build-system.scm
index 93f7efbb2b..fb23894bc1 100644
--- a/guix/build/node-build-system.scm
+++ b/guix/build/node-build-system.scm
@@ -208,7 +208,8 @@ (define (delete-dependencies absent)
       (jsobject-update*
        pkg-meta
        `("devDependencies" ,delete-from-jsobject (@))
-       `("dependencies" ,delete-from-jsobject (@))))))
+       `("dependencies" ,delete-from-jsobject (@))
+       `("peerDependencies" ,delete-from-jsobject (@))))))
 
 (define* (delete-lockfiles #:key inputs #:allow-other-keys)
   "Delete 'package-lock.json', 'yarn.lock', and 'npm-shrinkwrap.json', if they

base-commit: 1a0ff5cd83d3257efcab64740a1322de51fbc4a1
-- 
2.39.3

Message #8 received at 64203 <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Lars-Dominik Braun <lars <at> 6xq.net>, 64203 <at> debbugs.gnu.org
Subject: Re: [bug#64203] [PATCH] guix: node-build-system: Delete from
 peerDependencies too.
Date: Thu, 22 Jun 2023 11:29:46 +0200

Lars-Dominik Braun <lars <at> 6xq.net> writes:

> * guix/build/node-build-system.scm (delete-dependencies): Remove supplied
> dependencies from peerDependencies field too.
> ---
>
> Hi,
>
> this is required to build a new RStudio. I’m also validating it does
> not break anything here: https://ci.guix.gnu.org/jobset/node-peerdeps

LGTM. You can consider adding a note to the commit message that thix
needed due to a change in how more recent npm versions deal with
peerDependencies.

Cheers,
- Jelle

Message #11 received at 64203 <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <lars <at> 6xq.net>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: 64203 <at> debbugs.gnu.org
Subject: Re: [bug#64203] [PATCH] guix: node-build-system: Delete from
 peerDependencies too.
Date: Thu, 22 Jun 2023 12:05:45 +0200

Hi,

> LGTM. You can consider adding a note to the commit message that thix
> needed due to a change in how more recent npm versions deal with
> peerDependencies.

I don’t know anything about that change in npm unfortunately – this
is purely based on observations of failed builds. Do you have further
information on this?

Thanks,
Lars

Message #14 received at 64203 <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Lars-Dominik Braun <lars <at> 6xq.net>
Cc: 64203 <at> debbugs.gnu.org
Subject: Re: [bug#64203] [PATCH] guix: node-build-system: Delete from
 peerDependencies too.
Date: Thu, 22 Jun 2023 12:23:49 +0200

Lars-Dominik Braun <lars <at> 6xq.net> writes:

> Hi,
>
>> LGTM. You can consider adding a note to the commit message that thix
>> needed due to a change in how more recent npm versions deal with
>> peerDependencies.
>
> I don’t know anything about that change in npm unfortunately – this
> is purely based on observations of failed builds. Do you have further
> information on this?

The previous version of node we had packaged guix was v14, which came
with npm v6. The most recent version of node we have packaged in guix is
v18, which comes with npm v9.

From [1]: "In npm versions 3 through 6, peerDependencies were not
automatically installed, and would raise a warning if an invalid version
of the peer dependency was found in the tree. As of npm v7,
peerDependencies are installed by default."

HTH!
 - Jelle

[1]: https://docs.npmjs.com/cli/v9/configuring-npm/package-json#peerdependencies:

Message #19 received at 64203-done <at> debbugs.gnu.org (full text, mbox):

From: Lars-Dominik Braun <lars <at> 6xq.net>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: 64203-done <at> debbugs.gnu.org
Subject: Re: [bug#64203] [PATCH] guix: node-build-system: Delete from
 peerDependencies too.
Date: Thu, 22 Jun 2023 13:04:28 +0200

Hi,

> The previous version of node we had packaged guix was v14, which came
> with npm v6. The most recent version of node we have packaged in guix is
> v18, which comes with npm v9.
> 
> From [1]: "In npm versions 3 through 6, peerDependencies were not
> automatically installed, and would raise a warning if an invalid version
> of the peer dependency was found in the tree. As of npm v7,
> peerDependencies are installed by default."

thanks! Pushed to master as 37c2e94cec6cb8b5e0e93e7b6c712c3b187ca5db.

Cheers,
Lars

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.