GNU bug report logs - #64203
[PATCH] guix: node-build-system: Delete from peerDependencies too.

Previous Next

Full log

Message #14 received at 64203 <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Lars-Dominik Braun <lars <at> 6xq.net>
Cc: 64203 <at> debbugs.gnu.org
Subject: Re: [bug#64203] [PATCH] guix: node-build-system: Delete from
 peerDependencies too.
Date: Thu, 22 Jun 2023 12:23:49 +0200

Lars-Dominik Braun <lars <at> 6xq.net> writes:

> Hi,
>
>> LGTM. You can consider adding a note to the commit message that thix
>> needed due to a change in how more recent npm versions deal with
>> peerDependencies.
>
> I don’t know anything about that change in npm unfortunately – this
> is purely based on observations of failed builds. Do you have further
> information on this?

The previous version of node we had packaged guix was v14, which came
with npm v6. The most recent version of node we have packaged in guix is
v18, which comes with npm v9.

From [1]: "In npm versions 3 through 6, peerDependencies were not
automatically installed, and would raise a warning if an invalid version
of the peer dependency was found in the tree. As of npm v7,
peerDependencies are installed by default."

HTH!
 - Jelle

[1]: https://docs.npmjs.com/cli/v9/configuring-npm/package-json#peerdependencies:

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.